Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/improve postal code result endpoint #13

Merged
merged 11 commits into from
Feb 15, 2024

Conversation

juuso-j
Copy link
Collaborator

@juuso-j juuso-j commented Feb 13, 2024

improve postal code result endpoint

Description

Trello #56 and #57

Breakdown:

Files changed

  1. profiles/admin.py
    • Improve list view for PostalCodeResults
  2. profiles/api/serializers.py
    • Serialize _string fields
  3. profiles/api/views.py
    • Improve list view for PostalCodeResults
  4. profiles/tests/api/test_postal_code_result.py
    • Add/fix tests
  5. profiles/tests/api/test_question.py
    • Add test_questions_condition_states_after_post_answer

@juuso-j juuso-j added bug Something isn't working enhancement New feature or request labels Feb 13, 2024
@juuso-j juuso-j requested a review from ezkat February 13, 2024 10:32
@juuso-j juuso-j self-assigned this Feb 13, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (183c30f) 92.17% compared to head (fec1941) 92.16%.

Files Patch % Lines
profiles/api/utils.py 86.11% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #13      +/-   ##
===========================================
- Coverage    92.17%   92.16%   -0.01%     
===========================================
  Files           60       61       +1     
  Lines         2185     2247      +62     
  Branches       143      142       -1     
===========================================
+ Hits          2014     2071      +57     
- Misses         138      143       +5     
  Partials        33       33              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juuso-j juuso-j merged commit d750a40 into develop Feb 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants