Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/import living conditions #15

Merged
merged 4 commits into from
Feb 19, 2024
Merged

Conversation

juuso-j
Copy link
Collaborator

@juuso-j juuso-j commented Feb 15, 2024

Import living conditions question

Description

Trello #59

Breakdown:

Files changed

  1. profiles/admin.py
    • Display 'fi' fields
  2. profiles/management/commands/import_questions.py
    • Iterate completly through the sheet, but skip some questions
  3. profiles/tests/test_import_questions.py
    • Test skip questions

@juuso-j juuso-j added the enhancement New feature or request label Feb 15, 2024
@juuso-j juuso-j requested a review from ezkat February 15, 2024 11:16
@juuso-j juuso-j self-assigned this Feb 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d750a40) 92.16% compared to head (a95c33b) 92.32%.

Files Patch % Lines
profiles/admin.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #15      +/-   ##
===========================================
+ Coverage    92.16%   92.32%   +0.15%     
===========================================
  Files           61       61              
  Lines         2247     2254       +7     
  Branches       142      144       +2     
===========================================
+ Hits          2071     2081      +10     
+ Misses         143      141       -2     
+ Partials        33       32       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juuso-j juuso-j merged commit db59831 into develop Feb 19, 2024
3 checks passed
@juuso-j juuso-j mentioned this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants