Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/get sub questions conditions states #5

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

juuso-j
Copy link
Collaborator

@juuso-j juuso-j commented Feb 5, 2024

Get sub questions conditions states

Trello #53


Breakdown:

Files changed

  1. profiles/tests/api/test_question.py
    • Test get_sub_questions_conditions_states endpoint
  2. profiles/api/views.py
    • Add view that returns the condition states for sub question
  3. profiles/tests/conftest.py
    • Format

@juuso-j juuso-j added the enhancement New feature or request label Feb 5, 2024
@juuso-j juuso-j requested a review from ezkat February 5, 2024 10:00
@juuso-j juuso-j self-assigned this Feb 5, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ce16831) 92.31% compared to head (48cfff4) 92.32%.

Files Patch % Lines
profiles/api/views.py 87.50% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop       #5      +/-   ##
===========================================
+ Coverage    92.31%   92.32%   +0.01%     
===========================================
  Files           55       55              
  Lines         2055     2086      +31     
  Branches       131      133       +2     
===========================================
+ Hits          1897     1926      +29     
- Misses         126      127       +1     
- Partials        32       33       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juuso-j juuso-j merged commit ec5c961 into develop Feb 8, 2024
3 checks passed
@juuso-j juuso-j mentioned this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants