Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add takes_place_virtually and virtual_address to notification context #293

Merged

Conversation

ezkat
Copy link
Collaborator

@ezkat ezkat commented Oct 11, 2023

Add takes_place_virtually and virtual_address to notification context

Adds takes_place_virtually and virtual_address to notification context

Trello


Breakdown:

Notification context

  1. resources/models/reservation.py

    • Add reservation field 'takes_place_virtually' to notification context
    • Add reservation field 'virtual_address' to notification context if it exists
  2. resources/tests/test_reservation.py

    • Create test for notification context

@ezkat ezkat requested a review from SanttuA October 11, 2023 08:53
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7c42e07) 76.68% compared to head (d5036c3) 76.69%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #293      +/-   ##
===========================================
+ Coverage    76.68%   76.69%   +0.01%     
===========================================
  Files          498      498              
  Lines        26583    26595      +12     
  Branches      2708     2710       +2     
===========================================
+ Hits         20386    20398      +12     
  Misses        5672     5672              
  Partials       525      525              
Files Coverage Δ
resources/models/reservation.py 73.60% <100.00%> (+0.08%) ⬆️
resources/tests/test_reservation.py 100.00% <100.00%> (ø)
resources/tests/test_reservation_api.py 99.66% <ø> (-0.01%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ezkat ezkat merged commit 63498d4 into develop Oct 11, 2023
7 checks passed
@ezkat ezkat deleted the feature/add-takes-place-virtually-to-notification-context branch February 23, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants