Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed blocked reservations field requirements #299

Merged

Conversation

SanttuA
Copy link
Collaborator

@SanttuA SanttuA commented Nov 15, 2023

Type blocked reservation field requirements

Changes:

  • staff are allowed to create type blocked reservations without filling required fields

Related Trello card


Breakdown:

blocked reservation new rule

  1. resources/api/reservation.py
    • user with correct permissions can create a blocked reservation with no required fields

Changes:
- staff are allowed to create type blocked reservations without filling required fields
@SanttuA SanttuA requested a review from ezkat November 15, 2023 07:32
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8828b63) 76.67% compared to head (5649f56) 76.68%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #299      +/-   ##
===========================================
+ Coverage    76.67%   76.68%   +0.01%     
===========================================
  Files          500      500              
  Lines        26748    26769      +21     
  Branches      2726     2727       +1     
===========================================
+ Hits         20508    20529      +21     
  Misses        5712     5712              
  Partials       528      528              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SanttuA SanttuA merged commit 94f153e into develop Nov 30, 2023
7 checks passed
@SanttuA SanttuA deleted the feature/reservation-type-blocked-no-required-fields branch March 20, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants