Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send notification on blocked reservation type #305

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

ezkat
Copy link
Collaborator

@ezkat ezkat commented Dec 8, 2023

Don't send notification on blocked reservation type

Trello card


Breakdown:

Reservations

  1. resources/models/reservation.py
    • Skip notifications if reservation.type == blocked

@ezkat ezkat requested a review from SanttuA December 8, 2023 07:53
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ad9a54a) 76.74% compared to head (5c7a5c3) 76.71%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #305      +/-   ##
===========================================
- Coverage    76.74%   76.71%   -0.03%     
===========================================
  Files          500      500              
  Lines        26829    26870      +41     
  Branches      2732     2737       +5     
===========================================
+ Hits         20590    20614      +24     
- Misses        5711     5728      +17     
  Partials       528      528              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ezkat ezkat merged commit 5d9b2d8 into develop Dec 13, 2023
6 of 7 checks passed
@ezkat ezkat deleted the dont-send-notification-reservation-blocked-type branch February 23, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants