Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include block reservations in RA reports #308

Merged
merged 7 commits into from
Dec 21, 2023

Conversation

ezkat
Copy link
Collaborator

@ezkat ezkat commented Dec 20, 2023

Include block reservations in RA reports

Trello


Breakdown:

Ref. files tab for detailed changes

RA Reports

  1. resources/models/utils.py

    • function generate_reservation_xlsx: Changes to include block reservations
  2. resources/api/reservation.py

    • Add new query param: include_block_reservations
  3. respa_admin/static_src/js/reportForm.js

    • Changed filename to be more verbose

@ezkat ezkat requested a review from SanttuA December 20, 2023 08:26
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 60 lines in your changes are missing coverage. Please review.

Comparison is base (5d9b2d8) 76.71% compared to head (b22e5ca) 76.61%.

Files Patch % Lines
resources/models/utils.py 47.82% 53 Missing and 7 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #308      +/-   ##
===========================================
- Coverage    76.71%   76.61%   -0.11%     
===========================================
  Files          500      500              
  Lines        26870    26916      +46     
  Branches      2737     2750      +13     
===========================================
+ Hits         20614    20622       +8     
- Misses        5728     5765      +37     
- Partials       528      529       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ezkat ezkat merged commit 0a46a60 into develop Dec 21, 2023
5 of 7 checks passed
@ezkat ezkat deleted the ra/reservation-report-blocked-reservations branch February 23, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants