Fixed simple jwt env usage and settings #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - switched jwt expiration setting from `EXPIRATION_DELTA` to `ACCESS_TOKEN_LIFETIME` - changed env `JWT_LIFETIME` default from 3600 to 900 seconds - removed jwt `AUTH_HEADER_PREFIX` and updated `AUTH_HEADER_TYPES` to use env `JWT_AUTH_HEADER_PREFIX` - removed `PAYLOAD_HANDLER` which is not used by this package
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #318 +/- ##
===========================================
- Coverage 76.90% 76.89% -0.02%
===========================================
Files 500 500
Lines 27005 27000 -5
Branches 2753 2752 -1
===========================================
- Hits 20769 20762 -7
- Misses 5702 5704 +2
Partials 534 534 ☔ View full report in Codecov by Sentry. |
ezkat
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
EXPIRATION_DELTAtoACCESS_TOKEN_LIFETIMEJWT_LIFETIMEdefault from 3600 to 900 secondsAUTH_HEADER_PREFIXand updatedAUTH_HEADER_TYPESto use envJWT_AUTH_HEADER_PREFIXPAYLOAD_HANDLERwhich is not used by this package