Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/retrieve mobileunits in division #263

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

juuso-j
Copy link

@juuso-j juuso-j commented Mar 31, 2023

Retrieve mobileunits in division


Breakdown:

API

  1. mobility_data/api/views.py
    • Add division filter
  2. services/api.py
    • Add resolve_divisions helper function. Remove obsolete SearchSerializer

Tests

  1. mobility_data/tests/conftest.py
    • Fix coordinates, add ocd_id
  2. mobility_data/tests/test_api.py
    • Test division filter

@juuso-j juuso-j added the enhancement New feature or request label Mar 31, 2023
@juuso-j juuso-j requested a review from ezkat March 31, 2023 11:37
@juuso-j juuso-j self-assigned this Mar 31, 2023
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch coverage: 60.52% and project coverage change: +0.21 🎉

Comparison is base (4eb7ea7) 66.55% compared to head (f34a41d) 66.77%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #263      +/-   ##
===========================================
+ Coverage    66.55%   66.77%   +0.21%     
===========================================
  Files          216      216              
  Lines        12699    12673      -26     
  Branches      1629     1624       -5     
===========================================
+ Hits          8452     8462      +10     
+ Misses        3874     3835      -39     
- Partials       373      376       +3     
Impacted Files Coverage Δ
services/api.py 55.87% <42.10%> (+2.94%) ⬆️
mobility_data/api/views.py 64.23% <66.66%> (+0.15%) ⬆️
street_maintenance/api/views.py 66.27% <66.66%> (-0.02%) ⬇️
mobility_data/tests/conftest.py 100.00% <100.00%> (ø)
mobility_data/tests/test_api.py 100.00% <100.00%> (ø)
...treet_maintenance/management/commands/constants.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants