Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added self hosted fonts #275

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Added self hosted fonts #275

merged 1 commit into from
Sep 29, 2023

Conversation

SanttuA
Copy link

@SanttuA SanttuA commented Sep 26, 2023

Self hosted Open Sans fonts

Changes:

  • self hosted Google Open Sans 400 and 800 fonts
  • removed use of outside hosted Opens Sans, Overpass and Noto Serif fonts
  • brought over brand colors from hel-bootsrap-3 package to avoid outside use of Noto Serif

Related Trello card


Breakdown:

Font usage

  1. app/assets/styles/_application-variables.scss

    • copied brand colors from hel-bootsrap-3 to avoid using helsinki variables which contains Google hosted Noto Serif
  2. app/assets/styles/_turku-custom-styles.scss

    • added self hosted Open Sans 400 and 800
  3. app/assets/styles/customization/vantaa/customization.scss

    • removed Google hosted Open Sans
  4. app/assets/styles/main.scss

    • removed Helsinki variables import to avoid Google Hosted Noto Serif
  5. server/Html.js

    • removed outside hosted Open Sans and Overpass

Changes:
- self hosted Google Open Sans 400 and 800 fonts
- removed use of outside hosted Opens Sans, Overpass and Noto Serif fonts
- brought over brand colors from `hel-bootsrap-3` package to avoid outside use of Noto Serif
@SanttuA SanttuA requested a review from ezkat September 26, 2023 05:54
@SanttuA SanttuA merged commit ae4c56a into develop Sep 29, 2023
4 checks passed
@SanttuA SanttuA deleted the feature/font-self-hosting branch January 9, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants