This repository has been archived by the owner on Nov 15, 2021. It is now read-only.
Improve parse_and_sign
#716
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge CoZ Development into jseagrave21 Development
Merge CoZ Development into jseagrave21 Development
Merge CoZ Development into jseagrave21 Development
* Update ExtendedJsonRpcApi.py - add fix provided by @localhuman so original methods are returned as well as extended methods
…yOfZion#661) * Add the option -u (unittest-net) to prompt.py * Add unittest guildeline and add the smart contract source codes (UnitTest-SM.zip) to the fixtures package
for compatibility
* Fix ExtendedJsonRpcApi (CityOfZion#662) * Update ExtendedJsonRpcApi.py - add fix provided by @localhuman so original methods are returned as well as extended methods * Mute expected test stacktrace and clearly identify why an exception is thrown. (CityOfZion#663) * Add guideline for adding tests to the neo-privnet-unittest image (CityOfZion#661) * Add the option -u (unittest-net) to prompt.py * Add unittest guildeline and add the smart contract source codes (UnitTest-SM.zip) to the fixtures package * Add raw transaction building examples (CityOfZion#665) * Update neo-boa version to fix core building test
Merge CoZ Development into jseagrave21 Development
Merge CoZ Development into jseagrave21 Development
Merge CoZ Development into jseagrave21 Development
Merge CoZ Development into jseagrave21 development
Merge CoZ development into jseagrave21 development
- add tests for "showallaccounts" and "showallaccountstates"
Merge neo-python development into jseagrave21 development
Merge neo-python development into jseagrave21 development
- remove unnecessary logic
- add tests for `ImportMultiSigContractAddr`
- update logic so it is consistent with previous. - return `tx` on successful relay
- add tests for `parse_and_sign`
- update instructions to match reality
update fixture files
- update fixture files
ixje
suggested changes
Nov 14, 2018
- fix return type difference
- add logic to catch if `m` != len(publicKeys)
- add a test if minimum # of signatures required != len(publicKeys)
fix typo
- add the ability to input a from-addr for TestBuild (required for neo-boa)
for compatibility
Add GET & OPTIONS request functionality to JSON-RPC servers (CityOfZion#712)
|
@localhuman @ixje This PR is ready for your review please note that the change here https://github.com/CityOfZion/neo-python/pull/716/files#diff-354f30a63fb0907d4ad57269548329e3R23 was implemented to show neo-boa successfully pass |
Merge neo-python development into jseagrave21 development
5 tasks
- update to match CityOfZion#730
for compatibility
Merge neo-python development into jseagrave21 parse_and_sign
- restore required logic (not needed in `refactored-prompt`)
- make logic cohesive
|
I am planning on using these tests as the basis for the refactored tests for |
Merge CoZ development into jseagrave21 development
Gracefully handle NEP-5 balance query failures (CityOfZion#744)
5 tasks
Merge CoZ development into neo-python development
Merge CoZ development into jseagrave21 development
…into CityOfZion-development
jseagrave21
changed the title
parse_and_sign and ImportMultiSigContractAddrparse_and_sign
jseagrave21
force-pushed
the
parse_and_sign
branch
from
4448f76
to
da8cf8d
Compare
|
@metachris @localhuman please review this PR. I just updated it and it is working as intended. Please note I have edited This PR is necessary for establishing the new test fixtures so I can test the functionality I am working on for glaiming GAS from multisig addresses as mentioned by @ThomasLobker in # _neopython in Slack. |
This was referenced Mar 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) does this address, or what feature is it adding?
Improves
parse_and_signfunctionalityAdd test coverage
This PR verifies that Cannot sign multisig tx #697 is resolved.
Improves the instructions for updating test fixtures
NOTE: Required an update to the test fixtures:
-updated fixtures-
notif_fixtures_v9.tar.gz
fixtures_v9.tar.gz
How did you solve this problem?
Trial and Error. Special thanks to @dauTT and @ixje for helping me through.
How did you make sure your solution works?
Unittest
NOTE: Due to permission errors I was not able to run
make testso I am not sure how the changes in the fixtures (mainly the small advancement in height) has affected other tests. I was thinking it might work after the fixtures are uploaded to AWS.-updated-
make testworks athoughneo-boawill need to be updated.Are there any special changes in the code that we should be aware of?
Updated the unittest fixtures
Please check the following, if applicable:
make lint?make test?CHANGELOG.rst? (if not, please do)