Improve parameter parsing [02] #973

jseagrave21 · 2019-06-29T01:50:46Z

What current issue(s) does this address, or what feature is it adding?
NOTE: This PR is a continuation of #972
When manually testing contract invocation and build_run, I noticed that parameters entered via the command line were not parsed identically to those entered with the --i flag. This is because the --i flag used the gather_params helper function and the regular command line parsing did not.

How did you solve this problem?
I split out the parameter verification into a separate function: verify_params and added a user_entry flag to limit verification to user entered params.

verifies parameters input via command line and --i flag
ensures parameter input is identical
does not disrupt existing logic which had previously caused many errors in Improve parameter parsing #972

How did you make sure your solution works?
manual testing

Are there any special changes in the code that we should be aware of?
Yes, new parameter parsing affected some gas costs and one return value from previous tests. See efb6ef4
I think these are good changes seeing as they mirror the results if the --i flag was used.

Please check the following, if applicable:

Did you add any tests?
Did you run make lint?
Did you run make test?
Are you making a PR to a feature branch or development rather than master?
Did you add an entry to CHANGELOG.rst? (if not, please do)

- verifies parameters input via command line and --i flag - ensures parameter input is identical

coveralls · 2019-06-29T02:16:05Z

Coverage increased (+0.01%) to 85.328% when pulling 23b50e4 on jseagrave21:verify-params into cc6fd89 on CityOfZion:development.

ixje · 2019-07-01T06:24:08Z

neo/SmartContract/tests/test_gas_costs.py

-        expected_cost = Fixed8(1046600000)
-        expected_gas = Fixed8.FromDecimal(1.0)
+        expected_cost = Fixed8.FromDecimal(15.466)
+        expected_gas = Fixed8.FromDecimal(6.0)


Do you know why the GAS costs rises with 5 GAS? That really seems like a lot for (assuming) just an input type parsing difference.

The difference is the original code pushed the big_str as bytes and the updated code pushes it as a bytearray. Here are the input values just prior to being pushed onto the stack:

Original:

b'abababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababab' Length: 2048 b'6b657931' Length: 8 b'7075745f35' Length: 10

Updated:

bytearray(b'abababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababab') Length: 2048 b'6b657931' Length: 8 b'7075745f35' Length:10

Using the development branch, I get a result of 1.0 GAS used when invoking with b’abababab…' and 6.0 GAS used when invoking with b’ghghghgh…' so 5 GAS is the difference between parsing that size of an argument as a hex string vs parsing it as an ascii string. The changes in the test_gas_costs.py would seem to be correct if the parser is no longer arbitrarily converting strings to binary just because they look like hexadecimal values.

@hal0x2328

- based on discussion from @hal0x2328 and @ixje in Slack - adding to PR CityOfZion#973 because the change is so small

jseagrave21 · 2019-07-03T03:01:13Z

@ixje please note make test passes locally. You can see the failure is being caused by the snapshot argument which seems to be from #974.

ixje · 2019-07-22T06:29:56Z

note to self; check ceil and gas change impact

ixje · 2019-08-06T10:56:53Z

neo/Prompt/Commands/Invoke.py

@@ -331,7 +345,6 @@ def test_invoke(script, wallet, outputs, withdrawal_tx=None,
            # print("Used %s Gas " % engine.GasConsumed().ToString())

            consumed = engine.GasConsumed() - Fixed8.FromDecimal(10)
-            consumed = consumed.Ceil()


https://docs.neo.org/docs/en-us/tooldev/advanced/tx_execution.html#b02a262b

Assign Math.max(0, GasConsumed - 10).Ceiling() to InvocationTransaction.Gas as transaction's system fee. Note that system provides 10 Gas for free in each InvocationTransaction.

@hal0x2328 could you record your findings for GAS costs from Slack here for discussion? It would appear either the current implementation of neo-python (with Ceil rounding) is correct per the above documentation, or the documentation is outdated and no longer being utilized in neo-cli.

The documentation seems to match the code: https://github.com/neo-project/neo/blob/56174b8fc2e31bc0f300e4dab1f61bd8cf81ca6e/neo/Network/P2P/Payloads/InvocationTransaction.cs#L44-L46

Okay. In that case, I will remove this change.

…into verify-params

- update test_gas_costs.py based on using the `Ceil()` function

ixje

While testing

neo> sc build_run test-sc.py Fale False False 0510 02 bla [1234]
Saved output to test-sc.avm
Could not execute command: name 'bla' is not defined
  File "/Users/erik/Documents/code/test-issues/seagrave/venv/bin/np-prompt", line 11, in <module>
    load_entry_point('neo-python', 'console_scripts', 'np-prompt')()
  File "/Users/erik/Documents/code/test-issues/seagrave/neo/bin/prompt.py", line 382, in main
    loop.run_forever()
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/asyncio/base_events.py", line 523, in run_forever
    self._run_once()
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/asyncio/base_events.py", line 1758, in _run_once
    handle._run()
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/asyncio/events.py", line 88, in _run
    self._context.run(self._callback, *self._args)
  File "/Users/erik/Documents/code/test-issues/seagrave/neo/bin/prompt.py", line 234, in run
    traceback.print_stack()
Traceback (most recent call last):
  File "/Users/erik/Documents/code/test-issues/seagrave/neo/bin/prompt.py", line 220, in run
    cmd.execute(arguments)
  File "/Users/erik/Documents/code/test-issues/seagrave/neo/Prompt/Commands/SC.py", line 44, in execute
    return self.execute_sub_command(item, arguments[1:])
  File "/Users/erik/Documents/code/test-issues/seagrave/neo/Prompt/CommandBase.py", line 75, in execute_sub_command
    return self.__sub_commands[id].execute(arguments)
  File "/Users/erik/Documents/code/test-issues/seagrave/neo/Prompt/Commands/SC.py", line 80, in execute
    tx, result, total_ops, engine = BuildAndRun(arguments, PromptData.Wallet)
  File "/Users/erik/Documents/code/test-issues/seagrave/neo/Prompt/Commands/BuildNRun.py", line 72, in BuildAndRun
    debug_map=debug_map, invoke_attrs=invoke_attrs, owners=owners, enable_debugger=enable_debugger)
  File "/Users/erik/Documents/code/test-issues/seagrave/neo/Prompt/Commands/BuildNRun.py", line 96, in DoRun
    enable_debugger=enable_debugger, user_entry=True)
  File "/Users/erik/Documents/code/test-issues/seagrave/neo/Prompt/Commands/Invoke.py", line 473, in test_deploy_and_invoke
    param, abort = PromptUtils.verify_params(ContractParameterType(iarg), invoke_args[index])
  File "/Users/erik/Documents/code/test-issues/seagrave/neo/Prompt/Utils.py", line 325, in verify_params
    res = eval(param, {"__builtins__": {'bytearray': bytearray, 'bytes': bytes}}, {})
  File "<string>", line 1, in <module>
NameError: name 'bla' is not defined

test-sc.py

def Main(operation, args):
    if args[0] ==b'\x01\x02\x03\x04':
        return 1
    return 0

For some reason we must now wrap strings in double quotes "", so to fix this you must wrap bla in quotes. This was previously not necessary.

Also, if you provide a data that does not match the specified contract parameter type it used to throw exceptions that got caught and replaced with a warning e.g.

neo> sc build_run test-sc.py Fale False False 0510 02 "bla" "hoi"
Saved output to test-sc.avm
[I 190910 14:40:10 LevelDBImpl:45] Created DB at /Users/erik/.neopython/Chains/debugstorage
run `sc build_run help` to see supported queries

now it throws exceptions:

neo> sc build_run test-sc.py Fale False False 0510 02 "bla" "hoi"                                                                                                                                                                                                                               
Saved output to test-sc.avm 
Could not execute command: Please provide a list
  File "/Applications/PyCharm.app/Contents/helpers/pydev/pydevd.py", line 2060, in <module>
    main()
  File "/Applications/PyCharm.app/Contents/helpers/pydev/pydevd.py", line 2054, in main
    globals = debugger.run(setup['file'], None, None, is_module)
  File "/Applications/PyCharm.app/Contents/helpers/pydev/pydevd.py", line 1405, in run
    return self._exec(is_module, entry_point_fn, module_name, file, globals, locals)
  File "/Applications/PyCharm.app/Contents/helpers/pydev/pydevd.py", line 1412, in _exec
    pydev_imports.execfile(file, globals, locals)  # execute the script
  File "/Applications/PyCharm.app/Contents/helpers/pydev/_pydev_imps/_pydev_execfile.py", line 18, in execfile
    exec(compile(contents+"\n", file, 'exec'), glob, loc)
  File "./neo/bin/prompt.py", line 409, in <module>
    main()
  File "./neo/bin/prompt.py", line 382, in main
    loop.run_forever()
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/asyncio/base_events.py", line 523, in run_forever
    self._run_once()
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/asyncio/base_events.py", line 1758, in _run_once
    handle._run()
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/asyncio/events.py", line 88, in _run
    self._context.run(self._callback, *self._args)
  File "./neo/bin/prompt.py", line 234, in run
    traceback.print_stack()
Traceback (most recent call last):
  File "./neo/bin/prompt.py", line 220, in run
    cmd.execute(arguments)
  File "/Users/erik/Documents/code/test-issues/seagrave/neo/Prompt/Commands/SC.py", line 44, in execute
    return self.execute_sub_command(item, arguments[1:])
  File "/Users/erik/Documents/code/test-issues/seagrave/neo/Prompt/CommandBase.py", line 75, in execute_sub_command
    return self.__sub_commands[id].execute(arguments)
  File "/Users/erik/Documents/code/test-issues/seagrave/neo/Prompt/Commands/SC.py", line 80, in execute
    tx, result, total_ops, engine = BuildAndRun(arguments, PromptData.Wallet)
  File "/Users/erik/Documents/code/test-issues/seagrave/neo/Prompt/Commands/BuildNRun.py", line 72, in BuildAndRun
    debug_map=debug_map, invoke_attrs=invoke_attrs, owners=owners, enable_debugger=enable_debugger)
  File "/Users/erik/Documents/code/test-issues/seagrave/neo/Prompt/Commands/BuildNRun.py", line 96, in DoRun
    enable_debugger=enable_debugger, user_entry=True)
  File "/Users/erik/Documents/code/test-issues/seagrave/neo/Prompt/Commands/Invoke.py", line 473, in test_deploy_and_invoke
    param, abort = PromptUtils.verify_params(ContractParameterType(iarg), invoke_args[index])
  File "/Users/erik/Documents/code/test-issues/seagrave/neo/Prompt/Utils.py", line 338, in verify_params
    raise Exception("Please provide a list")
Exception: Please provide a list

I'm actually not happy with the error message it used to print either as it's useless. The example uses a str as second argument ("hoi") while it expects an array type (as indicated by contract parameter type 10). There is more information available in the code

neo-python/neo/Prompt/Utils.py

Lines 349 to 351 in 8061071

    
               raise Exception("Please provide a list") 
        
           else: 
        
               raise Exception("Unknown param type %s " % ptype.name)

but we're not using it.

another issue

neo> sc build_run test-sc.py Fale False False 0512 02 "bla" hoi
Saved output to test-sc.avm
[I 190910 14:48:09 LevelDBImpl:45] Created DB at /Users/erik/.neopython/Chains/debugstorage
Could not execute command: 18 is not a valid ContractParameterType
  File "/Users/erik/Documents/code/test-issues/seagrave/venv/bin/np-prompt", line 11, in <module>
    load_entry_point('neo-python', 'console_scripts', 'np-prompt')()
  File "/Users/erik/Documents/code/test-issues/seagrave/neo/bin/prompt.py", line 382, in main
    loop.run_forever()
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/asyncio/base_events.py", line 523, in run_forever
    self._run_once()
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/asyncio/base_events.py", line 1758, in _run_once
    handle._run()
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/asyncio/events.py", line 88, in _run
    self._context.run(self._callback, *self._args)
  File "/Users/erik/Documents/code/test-issues/seagrave/neo/bin/prompt.py", line 234, in run
    traceback.print_stack()
Traceback (most recent call last):
  File "/Users/erik/Documents/code/test-issues/seagrave/neo/bin/prompt.py", line 220, in run
    cmd.execute(arguments)
  File "/Users/erik/Documents/code/test-issues/seagrave/neo/Prompt/Commands/SC.py", line 44, in execute
    return self.execute_sub_command(item, arguments[1:])
  File "/Users/erik/Documents/code/test-issues/seagrave/neo/Prompt/CommandBase.py", line 75, in execute_sub_command
    return self.__sub_commands[id].execute(arguments)
  File "/Users/erik/Documents/code/test-issues/seagrave/neo/Prompt/Commands/SC.py", line 80, in execute
    tx, result, total_ops, engine = BuildAndRun(arguments, PromptData.Wallet)
  File "/Users/erik/Documents/code/test-issues/seagrave/neo/Prompt/Commands/BuildNRun.py", line 72, in BuildAndRun
    debug_map=debug_map, invoke_attrs=invoke_attrs, owners=owners, enable_debugger=enable_debugger)
  File "/Users/erik/Documents/code/test-issues/seagrave/neo/Prompt/Commands/BuildNRun.py", line 96, in DoRun
    enable_debugger=enable_debugger, user_entry=True)
  File "/Users/erik/Documents/code/test-issues/seagrave/neo/Prompt/Commands/Invoke.py", line 473, in test_deploy_and_invoke
    param, abort = PromptUtils.verify_params(ContractParameterType(iarg), invoke_args[index])
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/enum.py", line 307, in __call__
    return cls.__new__(cls, value)
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/enum.py", line 555, in __new__
    return cls._missing_(value)
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/enum.py", line 568, in _missing_
    raise ValueError("%r is not a valid %s" % (value, cls.__name__))
ValueError: 18 is not a valid ContractParameterType

It shouldn't throw exceptions but just use the exception information and notify that we have specified an invalid contract type.

overall

neo-python/neo/Prompt/Commands/Invoke.py

Line 189 in 22a3339

    
           param, abort = PromptUtils.verify_params(ContractParameterType(iarg), params[index])

does not handle exceptions at all, where as the originally used PrompUtils.gather_params does

neo-python/neo/Prompt/Utils.py

Lines 353 to 361 in 8061071

    
           except KeyboardInterrupt:  # Control-C pressed: exit 
        
               return None, True 
        
           except Exception as e: 
        
               print("Could not parse param as %s : %s " % (ptype, e)) 
        
               if do_continue: 
        
                   return gather_param(index, param_type, do_continue)

That's just what I happen to find and it is already making me uncomfortable

jseagrave21 · 2019-09-12T07:46:51Z

@ixje
BLUF: I think I have addressed all your comments. Please let me know if I am missing something.

Background: In your first comment, since the string 'bla' is not a bytearray or a bytes object, eval returns a NameError. I have included this case in testing and exceptions during eval or any other returns other than bytearray or bytes output will result in an Exception to provide a bytearray or bytes object.

I address both your second and third comments by incorporating exception handling into the user-entry process.

I was a little unsure of what you meant with Exception('Please provide a list'). This exception is now incorporated in the the exception handling which provides good feedback to the user.

Please let me know if I am missing something and thank you for your thorough review.

jseagrave21 · 2019-09-12T07:49:40Z

neo/Prompt/Utils.py

+            if isinstance(res, list):
+                return res, False
+        except Exception:
+            pass


This pass is necessary in case there is no exception thrown but eval does not evaluate a list object.

ixje · 2019-09-16T10:20:51Z

I think you're trying to resolve it in a too narrow context. Normally, it's good to not catch exceptions too 'broad', to make sure you don't have hidden issues. In this case I pointed at the difference of PrompUtils.gather_params() vs your verify_params for that specific reason.

The second issue I pointed out is not resolved

neo> sc build_run test-sc.py False False False fe10 02 bla []
Saved output to test-sc.avm
Could not execute command: local variable 'ptype' referenced before assignment
  File "/Users/erik/Documents/code/test-issues/seagrave/venv/bin/np-prompt", line 11, in <module>
    load_entry_point('neo-python', 'console_scripts', 'np-prompt')()
  File "/Users/erik/Documents/code/test-issues/seagrave/neo/bin/prompt.py", line 382, in main
    loop.run_forever()
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/asyncio/base_events.py", line 523, in run_forever
    self._run_once()
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/asyncio/base_events.py", line 1758, in _run_once
    handle._run()
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/asyncio/events.py", line 88, in _run
    self._context.run(self._callback, *self._args)
  File "/Users/erik/Documents/code/test-issues/seagrave/neo/bin/prompt.py", line 234, in run
    traceback.print_stack()
Traceback (most recent call last):
  File "/Users/erik/Documents/code/test-issues/seagrave/neo/Prompt/Commands/Invoke.py", line 477, in test_deploy_and_invoke
    ptype = ContractParameterType(iarg)
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/enum.py", line 307, in __call__
    return cls.__new__(cls, value)
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/enum.py", line 555, in __new__
    return cls._missing_(value)
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/enum.py", line 568, in _missing_
    raise ValueError("%r is not a valid %s" % (value, cls.__name__))
ValueError: 254 is not a valid ContractParameterType

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/erik/Documents/code/test-issues/seagrave/neo/bin/prompt.py", line 220, in run
    cmd.execute(arguments)
  File "/Users/erik/Documents/code/test-issues/seagrave/neo/Prompt/Commands/SC.py", line 44, in execute
    return self.execute_sub_command(item, arguments[1:])
  File "/Users/erik/Documents/code/test-issues/seagrave/neo/Prompt/CommandBase.py", line 75, in execute_sub_command
    return self.__sub_commands[id].execute(arguments)
  File "/Users/erik/Documents/code/test-issues/seagrave/neo/Prompt/Commands/SC.py", line 80, in execute
    tx, result, total_ops, engine = BuildAndRun(arguments, PromptData.Wallet)
  File "/Users/erik/Documents/code/test-issues/seagrave/neo/Prompt/Commands/BuildNRun.py", line 72, in BuildAndRun
    debug_map=debug_map, invoke_attrs=invoke_attrs, owners=owners, enable_debugger=enable_debugger)
  File "/Users/erik/Documents/code/test-issues/seagrave/neo/Prompt/Commands/BuildNRun.py", line 96, in DoRun
    enable_debugger=enable_debugger, user_entry=True)
  File "/Users/erik/Documents/code/test-issues/seagrave/neo/Prompt/Commands/Invoke.py", line 488, in test_deploy_and_invoke
    print("Could not parse param as %s : %s " % (ptype, e))
UnboundLocalError: local variable 'ptype' referenced before assignment

I also think we can improve the error message:

neo> sc build_run test-sc.py False False False 0710 02 bla hoi
Saved output to test-sc.avm
[I 190916 12:19:15 LevelDBImpl:45] Created DB at /Users/erik/.neopython/Chains/debugstorage
Could not parse param as Array : Please provide a list

which param is wrong?

…into verify-params

jseagrave21 added 5 commits June 28, 2019 01:55

impliment parameter verification function

528fb1e

- verifies parameters input via command line and --i flag - ensures parameter input is identical

implement user_entry flag to ensure existing logic is not disrupted

485904e

add tests for too few params entered

0f1e242

updated CHANGELOG.rst

10570ba

update tests

efb6ef4

ixje reviewed Jul 1, 2019

View reviewed changes

remove Ceiling rounding for invocation GAS costs

98c8863

- based on discussion from @hal0x2328 and @ixje in Slack - adding to PR CityOfZion#973 because the change is so small

ixje added 3 commits July 3, 2019 09:42

Merge branch 'development' into verify-params

b7ffb25

restore user_entry flag

29e7fc4

fix lint error

4d32219

ixje reviewed Aug 6, 2019

View reviewed changes

ixje force-pushed the development branch from 204177f to 88e0c89 Compare August 21, 2019 11:27

jseagrave21 added 4 commits September 9, 2019 22:21

Merge branch 'development' of https://github.com/CityOfZion/neo-python …

935e526

…into verify-params

update Changelog for 0.9.1-dev

9611d83

revert removal of Ceil() function based on CityOfZion#973 (review)

016f30d

update unittest

22a3339

- update test_gas_costs.py based on using the `Ceil()` function

ixje suggested changes Sep 10, 2019

View reviewed changes

jseagrave21 pushed a commit to jseagrave21/neo-python that referenced this pull request Sep 12, 2019

improve per CityOfZion#973 (review)

6c8cc5c

jseagrave21 commented Sep 12, 2019

View reviewed changes

jseagrave21 pushed a commit to jseagrave21/neo-python that referenced this pull request Sep 12, 2019

improve per CityOfZion#973 (review)

d27975e

jseagrave21 force-pushed the verify-params branch from 6c8cc5c to d27975e Compare September 12, 2019 08:00

improve per CityOfZion#973 (review)

19fe4e2

jseagrave21 force-pushed the verify-params branch from d27975e to 19fe4e2 Compare September 12, 2019 08:05

jseagrave21 added 2 commits September 22, 2019 10:28

improve per CityOfZion#973 (comment)

9eddbe2

Merge branch 'development' of https://github.com/CityOfZion/neo-python …

435063d

…into verify-params

Merge branch 'development' of https://github.com/CityOfZion/neo-python …

23b50e4

…into verify-params

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve parameter parsing [02] #973

Improve parameter parsing [02] #973

jseagrave21 commented Jun 29, 2019 •

edited

Loading

coveralls commented Jun 29, 2019 •

edited

Loading

ixje Jul 1, 2019

jseagrave21 Jul 1, 2019

hal0x2328 Jul 1, 2019

jseagrave21 commented Jul 3, 2019

ixje commented Jul 22, 2019

ixje Aug 6, 2019

jseagrave21 Aug 6, 2019 •

edited

Loading

ixje Sep 10, 2019

jseagrave21 Sep 10, 2019

ixje left a comment

jseagrave21 commented Sep 12, 2019 •

edited

Loading

jseagrave21 Sep 12, 2019 •

edited

Loading

ixje commented Sep 16, 2019

	raise Exception("Please provide a list")
	else:
	raise Exception("Unknown param type %s " % ptype.name)

	except KeyboardInterrupt: # Control-C pressed: exit

	return None, True

	except Exception as e:

	print("Could not parse param as %s : %s " % (ptype, e))
	if do_continue:
	return gather_param(index, param_type, do_continue)

Improve parameter parsing [02] #973

Are you sure you want to change the base?

Improve parameter parsing [02] #973

Conversation

jseagrave21 commented Jun 29, 2019 • edited Loading

coveralls commented Jun 29, 2019 • edited Loading

ixje Jul 1, 2019

Choose a reason for hiding this comment

jseagrave21 Jul 1, 2019

Choose a reason for hiding this comment

hal0x2328 Jul 1, 2019

Choose a reason for hiding this comment

jseagrave21 commented Jul 3, 2019

ixje commented Jul 22, 2019

ixje Aug 6, 2019

Choose a reason for hiding this comment

jseagrave21 Aug 6, 2019 • edited Loading

Choose a reason for hiding this comment

ixje Sep 10, 2019

Choose a reason for hiding this comment

jseagrave21 Sep 10, 2019

Choose a reason for hiding this comment

ixje left a comment

Choose a reason for hiding this comment

jseagrave21 commented Sep 12, 2019 • edited Loading

jseagrave21 Sep 12, 2019 • edited Loading

Choose a reason for hiding this comment

ixje commented Sep 16, 2019

jseagrave21 commented Jun 29, 2019 •

edited

Loading

coveralls commented Jun 29, 2019 •

edited

Loading

jseagrave21 Aug 6, 2019 •

edited

Loading

jseagrave21 commented Sep 12, 2019 •

edited

Loading

jseagrave21 Sep 12, 2019 •

edited

Loading