Skip to content

Commit

Permalink
Merge pull request #251 from nathanchance/fix-build-targets
Browse files Browse the repository at this point in the history
tc_build: llvm: Move use of build_targets out of ninja_cmd
  • Loading branch information
nathanchance authored Nov 8, 2023
2 parents ed9d47f + c6765eb commit 5931a24
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions tc_build/llvm.py
Original file line number Diff line number Diff line change
Expand Up @@ -143,12 +143,12 @@ def build(self):
raise RuntimeError('BOLT requested without a builder?')

build_start = time.time()
ninja_cmd = ['ninja', '-C', self.folders.build, *self.build_targets]
self.run_cmd(ninja_cmd)
base_ninja_cmd = ['ninja', '-C', self.folders.build]
self.run_cmd([*base_ninja_cmd, *self.build_targets])

if self.check_targets:
check_targets = [f"check-{target}" for target in self.check_targets]
self.run_cmd([*ninja_cmd, *check_targets])
self.run_cmd([*base_ninja_cmd, *check_targets])

tc_build.utils.print_info(f"Build duration: {tc_build.utils.get_duration(build_start)}")

Expand All @@ -160,7 +160,7 @@ def build(self):
install_targets = [f"install-{target}" for target in self.install_targets]
else:
install_targets = ['install']
self.run_cmd([*ninja_cmd, *install_targets], capture_output=True)
self.run_cmd([*base_ninja_cmd, *install_targets], capture_output=True)
tc_build.utils.create_gitignore(self.folders.install)

def can_use_perf(self):
Expand Down

0 comments on commit 5931a24

Please sign in to comment.