New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add present gift for dark background #260

Open

eighnjel wants to merge 1 commit into master from add-icon-present-dark

Contributor

eighnjel commented Jan 26, 2018

Overview:

Add present icon for dark backgrounds (see below for current and new)

Screenshots/GIFs:

Testing:

Unit tests
Manual tests:
- Chrome
- Safari
- IE10

Roll Out:

Before merging:
- Updated docs
- Bumped version in package.json
  - Breaking change? Run npm version minor
  - Backward compatible change? Run npm version patch
  - Only changing documentation? All good. Skip this step.
After merging:
- Deployed updated docs (make deploy-docs)


          add present gift for dark background

20caaa0

Contributor

CarlNelson commented Jan 26, 2018

We might want to adjust the colors of the dark background version. The white outline + dark background of the gift is a bit intense.

Contributor Author

eighnjel commented Jan 26, 2018

cc @mischelle-m who's working on it

Contributor

mischelle-m commented Jan 26, 2018

changed white outline into @neutral_silver to reduce the intense contrast, thoughts @CarlNelson?

Contributor

CarlNelson commented Jan 26, 2018

Still very visually jarring, let's chat.

Contributor Author

eighnjel commented Jan 29, 2018

We're just going to change this, so we can pause on iteration for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet