Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

combined this into another branch to avoid version issues. ignore #841

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Maddiebusta
Copy link
Contributor

@Maddiebusta Maddiebusta commented Oct 18, 2023

Jira: PRTL-4461

Overview:

Previously the screenreader would only read "show more" on a truncated quoted message so there was no way of knowing what it was referring to. I added the timestamp to the arialabel so the screenreader will read out more valuable information of what message you are expanding.

Testing:

  • Unit tests
  • Manual tests:
    • Chrome
    • Safari
    • IE11

Roll Out:

  • Before merging:
    • Updated docs
    • Bumped version in package.json
      • Breaking change?
        • If it is a beta component run npm version minor
        • If the component is not in beta run npm version major
      • New component or backward-compatible component feature change? Run npm version minor
      • Only changing documentation? All good. Skip this step.
    • After creating a new component, make sure to add it to the Components List in ComponentsView.jsx. To do so:
      • Add a screenshot of the component in docs/assets/img with the format <COMPONENT URL LINK>.png
  • After merging:
    • Deployed updated docs (make deploy-docs)
    • Posted in #eng if I made a breaking change to a beta component

@Maddiebusta Maddiebusta changed the title fix: adding more details to arialabel of show more button combined this into another branch to avoid version issues. ignore Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant