PolarBoundaryCondition for tracer + views for AbstractOperations
#3953
+285
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simone-silvestri
changed the title
PolarBoundaryCondition for tracer Fields on LatitudeLongitudeGrids that reach the poles
…gans.jl into ss/top-boundary-condition
glwagner
approved these changes
Nov 23, 2024
glwagner
reviewed
Nov 23, 2024
|
|
||
| if φmin == - 90 | ||
| _, LY, LZ = loc | ||
| field = Field{Nothing, LY, LZ}(grid; indices = (:, 1, :)) |
There was a problem hiding this comment.
But should LY actually be flipped? Eg this is Face for a Center location. (It may not matter)
There was a problem hiding this comment.
Probably you are right. I have found out unfortunately that reductions on windowed fields do not work. I ll try to make it work so here we can do
mean!(windowed_field, full_field)…gans.jl into ss/top-boundary-condition
simone-silvestri
changed the title
PolarBoundaryCondition for tracer Fields on LatitudeLongitudeGrids that reach the polesPolarBoundaryCondition for tracer + Reductions on reduced windowed field
simone-silvestri
changed the title
PolarBoundaryCondition for tracer + Reductions on reduced windowed fieldPolarBoundaryCondition for tracer + views for AbstractOperations
|
In the end, using fields in boundary conditions is a bit too complicated because fields are defined after boundary conditions making it a bit of a mess. For this reason, I just wrote a very simple averaging kernel in the polar boundary conditions file. The improvements for reductions on windowed fields still stand though, so I have added some tests also to make sure that reductions on windowed fields work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
FluxBoundaryConditionis not correct on a latitude-longitude grid that covers the whole earth, i.e. whenlatitude = (-90, 90).The actual boundary condition (for tracers) should be a value boundary condition that holds the average of the last / first row.
Vectors are a little more complicated because we need to account for the frame of reference.
(We can probably do that in a new PR)
This is required mainly for input data define on a
LatitudeLongitudeGridthat needs interpolation on full spherical grids for global ocean simulations.As part of this PR, to allow reducing on the last / first row of the
LatitudeLongitudeGridI needed to implement reductions on windowed reduced fields, which required extendingviewsforAbstractOperationsThe implementation is not final since it does not account for the case of an array (non-field) being part of an
AbstractOperation. But I guess we can tackle that case when we encounter it.