Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add migrate approvers and compare files scripts #206

Merged
merged 6 commits into from
Dec 12, 2024
Merged

Conversation

sanchegm
Copy link
Collaborator

Description

  • Add JSON file approver migration script to migrate approver values into the DB from the existing JSON file.
  • Updated docs and links to reflect the change.
  • Rename load.py to csv_load.py
  • Add script to compare JSON file and API response saved to JSON file.

Issue Ticket Number and Link

N/A

Checklist

Remove any options that are not applicable

[X ] I have reviewed the how-to guide and the contributing file.

[X] I have run required code checks and resolved any blockers.

[X] I have created the necessary tests to show my changes are effective and work as intended.

[X] I have thoroughly commented my code, especially in more complex areas.

[X] I have updated any necessary documentation.

Screenshots / Recordings
N/A

- Add "ensure_ascii": false param to account for special characters
- Add more formatting to directly match the old JSON format.
- Fix formatting error with subgroups object
- Change how names are displayed.
- Only add approvers array if there are approvers.
- Add JSON file approver migration script to migrate approver values into the DB from the existing JSON file.
- Updated docs and links to reflect the change.
- Rename load.py to csv_load.py
- Formatting
- Add script to compare JSON file and API response saved to JSON file.
@sanchegm sanchegm marked this pull request as ready for review December 11, 2024 19:07
@sanchegm sanchegm requested a review from liammulh December 11, 2024 19:07
Copy link
Member

@liammulh liammulh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Base automatically changed from gs-api-updates to main December 11, 2024 20:35
@sanchegm sanchegm merged commit 164cccc into main Dec 12, 2024
5 checks passed
@sanchegm sanchegm deleted the gs-migrate-json branch December 12, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants