Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Make CI fail if code isn't formatted properly #61

Merged
merged 3 commits into from
Oct 8, 2024
Merged

ci: Make CI fail if code isn't formatted properly #61

merged 3 commits into from
Oct 8, 2024

Conversation

liammulh
Copy link
Member

@liammulh liammulh commented Jul 3, 2024

To test this, I improperly formatted tasks.py. It failed, which is expected:

fail

Check out the failed CI job here.

Once approved, I will revert tasks.py.

For:
#60

@liammulh liammulh requested a review from sanchegm July 3, 2024 17:54
To test this, I improperly formatted `tasks.py`. I expect CI to fail.

For:
#60
@liammulh liammulh changed the title Make CI fail if code isn't formatted properly ci: Make CI fail if code isn't formatted properly Jul 8, 2024
@sanchegm sanchegm closed this Aug 9, 2024
@sanchegm sanchegm deleted the lm-60 branch August 9, 2024 22:17
@sanchegm sanchegm restored the lm-60 branch August 9, 2024 22:18
@sanchegm sanchegm reopened this Aug 9, 2024
Copy link
Collaborator

@sanchegm sanchegm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@liammulh liammulh merged commit 1ef472b into main Oct 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants