-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⭐ new transfer.py
module
#382
Conversation
More tests are probably needed but it is in good shape. |
Right now I believe the way I wrote the code is being supported by 3.9. So yes we can do a later PR. Hopefully with some shell scripting tool like sed to automatically replace all the typing. |
https://adamj.eu/tech/2021/05/21/python-type-hints-how-to-upgrade-syntax-with-pyupgrade/ |
Is it normal that it doesn't pass the test now? |
Yes, working on this. It is a draft and there are still some problems. |
* Add docs focused on contributing and document several processes ----- Co-authored-by: Philippe Miron <[email protected]> Co-authored-by: Shane Elipot <[email protected]>
* hurdat2 data adapter * use CF conventions * improve warning when it cannot be determined whether the remote file is new or not * increment revision --------- Co-authored-by: Shane Elipot <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files📢 Thoughts on this report? Let us know! |
to keep up with main
@kevinsantana11 I think we should merge, what do you think? |
I'll start a demo repo notebook next |
@kevinsantana11 can we merge? |
@selipot yes, please go ahead and merge |
This is the start of a draft PR to implement the
transfer
module for the wind driven models of Lilly and Elipot 2021 and Elipot and Gille 2009.