-
Notifications
You must be signed in to change notification settings - Fork 33
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
pre-commit: add more comprehensive golang linting rules
Signed-off-by: Maryam Tahhan <[email protected]>
- Loading branch information
1 parent
879dc7b
commit 61d6677
Showing
33 changed files
with
196 additions
and
47 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,118 @@ | ||
| run: | ||
| timeout: 5m | ||
| linters-settings: | ||
| dupl: | ||
| threshold: 150 | ||
| goconst: | ||
| min-len: 2 | ||
| min-occurrences: 3 | ||
| gocritic: | ||
| enabled-tags: | ||
| - diagnostic | ||
| - experimental | ||
| - opinionated | ||
| - performance | ||
| - style | ||
| disabled-checks: | ||
| - dupImport # https://github.com/go-critic/go-critic/issues/845 | ||
| - ifElseChain | ||
| - octalLiteral | ||
| goimports: | ||
| local-prefixes: github.com/golangci/golangci-lint | ||
|
|
||
| govet: | ||
| enable: | ||
| - shadow | ||
| settings: | ||
| printf: | ||
| funcs: | ||
| - (github.com/golangci/golangci-lint/pkg/logutils.Log).Infof | ||
| - (github.com/golangci/golangci-lint/pkg/logutils.Log).Warnf | ||
| - (github.com/golangci/golangci-lint/pkg/logutils.Log).Errorf | ||
| - (github.com/golangci/golangci-lint/pkg/logutils.Log).Fatalf | ||
| lll: | ||
| line-length: 140 | ||
| misspell: | ||
| locale: US | ||
|
|
||
| # output configuration options | ||
| output: | ||
| # The formats used to render issues. | ||
| # Formats: | ||
| # - `colored-line-number` | ||
| # - `line-number` | ||
| # - `json` | ||
| # - `colored-tab` | ||
| # - `tab` | ||
| # - `html` | ||
| # - `checkstyle` | ||
| # - `code-climate` | ||
| # - `junit-xml` | ||
| # - `github-actions` | ||
| # - `teamcity` | ||
| # - `sarif` | ||
| # Output path can be either `stdout`, `stderr` or path to the file to write to. | ||
| # | ||
| # For the CLI flag (`--out-format`), multiple formats can be specified by separating them by comma. | ||
| # The output can be specified for each of them by separating format name and path by colon symbol. | ||
| # Example: "--out-format=checkstyle:report.xml,json:stdout,colored-line-number" | ||
| # The CLI flag (`--out-format`) override the configuration file. | ||
| # | ||
| # Default: | ||
| # formats: | ||
| # - format: colored-line-number | ||
| # path: stdout | ||
| formats: | ||
| - format: colored-line-number | ||
| path: stdout | ||
| # Print lines of code with issue. | ||
| # Default: true | ||
| print-issued-lines: true | ||
| # Print linter name in the end of issue text. | ||
| # Default: true | ||
| print-linter-name: true | ||
| # Make issues output unique by line. | ||
| # Default: true | ||
| uniq-by-line: false | ||
| # Add a prefix to the output file references. | ||
| # Default: "" | ||
| path-prefix: "" | ||
| # Sort results by the order defined in `sort-order`. | ||
| # Default: false | ||
| sort-results: true | ||
| # Order to use when sorting results. | ||
| # Require `sort-results` to `true`. | ||
| # Possible values: `file`, `linter`, and `severity`. | ||
| # | ||
| # If the severity values are inside the following list, they are ordered in this order: | ||
| # 1. error | ||
| # 2. warning | ||
| # 3. high | ||
| # 4. medium | ||
| # 5. low | ||
| # Either they are sorted alphabetically. | ||
| # | ||
| # Default: ["file"] | ||
| sort-order: | ||
| - linter | ||
| - severity | ||
| - file # filepath, line, and column. | ||
| # Show statistics per linter. | ||
| # Default: false | ||
| show-stats: true | ||
| linters: | ||
| # # Disable all linters. | ||
| # # Default: false | ||
| disable-all: true | ||
| # # Enable specific linter | ||
| # # https://golangci-lint.run/usage/linters/#enabled-by-default | ||
| enable: | ||
| - dupl | ||
| - gofmt | ||
| - goimports | ||
| - ineffassign | ||
| - misspell | ||
| - nolintlint | ||
| - whitespace | ||
| - asciicheck | ||
| # # Enable only fast linters from enabled linters set (first run won't be fast) | ||
| # # Default: false | ||
| fast: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,15 @@ | ||
| module github.com/CloudNativeDataPlane/cndp/lang/go/stats/metrics | ||
|
|
||
| go 1.18 | ||
| go 1.22 | ||
|
|
||
| require github.com/fsnotify/fsnotify v1.5.1 | ||
| require ( | ||
| github.com/fsnotify/fsnotify v1.5.1 | ||
| github.com/stretchr/testify v1.9.0 | ||
| ) | ||
|
|
||
| require ( | ||
| github.com/davecgh/go-spew v1.1.1 // indirect | ||
| github.com/pmezard/go-difflib v1.0.0 // indirect | ||
| golang.org/x/sys v0.0.0-20210630005230-0f9fa26af87c // indirect | ||
| gopkg.in/yaml.v3 v3.0.1 // indirect | ||
| ) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,14 @@ | ||
| github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c= | ||
| github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38= | ||
| github.com/fsnotify/fsnotify v1.5.1 h1:mZcQUHVQUQWoPXXtuf9yuEXKudkV2sx1E06UadKWpgI= | ||
| github.com/fsnotify/fsnotify v1.5.1/go.mod h1:T3375wBYaZdLLcVNkcVbzGHY7f1l/uK5T5Ai1i3InKU= | ||
| github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM= | ||
| github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4= | ||
| github.com/stretchr/testify v1.9.0 h1:HtqpIVDClZ4nwg75+f6Lvsy/wHu+3BoSGCbBAcpTsTg= | ||
| github.com/stretchr/testify v1.9.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY= | ||
| golang.org/x/sys v0.0.0-20210630005230-0f9fa26af87c h1:F1jZWGFhYfh0Ci55sIpILtKKK8p3i2/krTr0H1rg74I= | ||
| golang.org/x/sys v0.0.0-20210630005230-0f9fa26af87c/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= | ||
| gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM= | ||
| gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0= | ||
| gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA= | ||
| gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM= |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| module github.com/CloudNativeDataPlane/cndp/lang/go/tools/pkgs/asciichart | ||
|
|
||
| go 1.18 | ||
| go 1.22 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| module github.com/CloudNativeDataPlane/cndp/lang/go/tools/pkgs/hexdump | ||
|
|
||
| go 1.18 | ||
| go 1.22 |
Oops, something went wrong.