Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cndp-frr: add an example showing CNET + FRR #348

Merged
merged 11 commits into from
Nov 13, 2023

Conversation

maryamtahhan
Copy link
Contributor

@maryamtahhan maryamtahhan commented Nov 9, 2023

Add an example that shows cnet working with frr
TODO

  • update license header on all files
  • fix missing Empty lines at the end of file
  • Debug double free issue on cnet close up
CNDP-cli:/> 
>>> Terminating with signal 2
    Close lport 0 - 'eth0:0'
    Close lport 1 - 'eth1:0'
double free or corruption (!prev)
Aborted (core dumped)
  • Fix super linter issues

Signed-off-by: Maryam Tahhan <[email protected]>
Signed-off-by: Maryam Tahhan <[email protected]>
Signed-off-by: Maryam Tahhan <[email protected]>
@maryamtahhan
Copy link
Contributor Author

Hey @KeithWiles

Sorry for such a big submission in one go. It's ready for review now.

Thanks

@KeithWiles
Copy link
Contributor

As Keith is famous for huge PRs it only seems reasonable. I will try to have a look today. Thank you.

Copy link
Contributor

@KeithWiles KeithWiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a look and see if we need to do any of the changes and if not then I can approve.

Thank you

examples/cndp-frr/docker/cnetfwd-graph.jsonc Outdated Show resolved Hide resolved
examples/cndp-frr/docker/cnetfwd-graph.jsonc Outdated Show resolved Hide resolved
examples/cndp-frr/scripts/cleanup-demo.sh Outdated Show resolved Hide resolved
@KeithWiles KeithWiles merged commit 51ad092 into CloudNativeDataPlane:main Nov 13, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants