Merge pull request #299 from CocoaPods/reintegration

Show an alert if we're going to re-integrate the pods dir

CHANGELOG.md

@@ -1,5 +1,9 @@
 ## master
 
+* Show an alert if CP is going to re-integrate your project  
+  [orta](https://github.com/orta)  
+  [#299](https://github.com/CocoaPods/CocoaPods-app/pull/299)
+
 * Polish for Source Menus & Pod Autocomplete improvements  
   [orta](https://github.com/orta)  
   [#298](https://github.com/CocoaPods/CocoaPods-app/pull/298)

app/CPReflectionService/RBObject+CocoaPods.rb

@@ -58,7 +58,14 @@ def self.analyze_podfile(podfile, installation_root)
       end
 
       uses_frameworks = config.podfile.target_definitions.first.last.to_hash["uses_frameworks"]
-      { "projects" => user_projects, "pod_targets" => pod_targets, "uses_frameworks" => uses_frameworks}
+      last_installed_version = config.sandbox.manifest.cocoapods_version.to_s
+
+      {
+        "projects" => user_projects,
+        "pod_targets" => pod_targets,
+        "uses_frameworks" => uses_frameworks,
+        "cocoapods_build_version" => last_installed_version
+      }
     end
 
     def self.sources_manager

app/CocoaPods/CPDocumentController.swift

@@ -73,9 +73,9 @@ class CPDocumentController: NSDocumentController {
       }
       else {
         let projectName = xcodeprojURL.lastPathComponent!
-        let localized = NSLocalizedString("POD_DEINTEGRATE_CONFIRMATION", comment: "")
+        let localized = ~"POD_DEINTEGRATE_CONFIRMATION"
         let alert = NSAlert()
-        alert.messageText = NSLocalizedString("POD_DEINTEGRATE_INFO", comment: "")
+        alert.messageText = ~"POD_DEINTEGRATE_INFO"
         alert.informativeText = String.localizedStringWithFormat(localized, projectName)
         alert.runModal()
       }

app/CocoaPods/CPPodfileEditorViewController.swift

@@ -342,7 +342,18 @@ extension EditorLineSelection {
 extension CPPodfileEditorViewController: CPUserProjectDelegate {
 
   func contentDidChangeinUserProject(userProject: CPUserProject) {
-    editor.string = userProject.contents
+    let contentChanged = editor.string != userProject.contents
+    let appIsActive = NSApplication.sharedApplication().active
+
+    if contentChanged && !appIsActive {
+      let selection = editor.textView.selectedRange()
+      let scroll = editor.scrollView.visibleRect
+
+      editor.string = userProject.contents
+
+      editor.textView.selectedRange = selection
+      editor.scrollView.scrollPoint(scroll.origin)
+    }
 
     // Passing the message on to the syntax checker
     syntaxChecker.textDidChange(NSNotification(name: "", object: nil))

app/CocoaPods/CPPodfilePluginCoordinator.swift

@@ -49,7 +49,7 @@ class CPPodfilePluginCoordinator: NSObject {
 
       dispatch_async(dispatch_get_main_queue()) {
         let inflectedPlugin = (self.pluginsToInstall.count == 1) ? "plugin" : "plugins"
-        self.controller.showWarningLabelWithSender("You need to install \(self.pluginsToInstall.count) \(inflectedPlugin) for this Podfile", actionTitle: "Install", target: self, action: "showInstaller", animated:true)
+        self.controller.showWarningLabelWithSender("You need to install \(self.pluginsToInstall.count) \(inflectedPlugin) for this Podfile", actionTitle: "Install", target: self, action: #selector(CPPodfilePluginCoordinator.showInstaller), animated:true)
       }
     }
   }

app/CocoaPods/CPPodfileViewController.swift

@@ -56,12 +56,31 @@ class CPPodfileViewController: NSViewController, NSTabViewDelegate {
     // we should show "Podfile for ProjectName" instead
     userProject.registerForFullMetadataCallback {
       guard let targets = self.userProject.xcodeIntegrationDictionary["projects"] as? [String:AnyObject] else { return }
-      if targets.keys.count == 1 {
-        let project = targets.keys.first!
-        let url = NSURL(fileURLWithPath: project)
-        let name = url.lastPathComponent!.stringByReplacingOccurrencesOfString(".xcproj", withString: "")
-        self.actionTitleLabel.stringValue = "Podfile for \(name)"
-      }
+      self.updatePodfileNameIfPossible(targets)
+    }
+  }
+
+  /// As CP will deintegrate, and re-integrate that app, we should show a warning
+  /// that is is going to happen
+  /// buildVersion will be cast to a string
+  func shouldShowInstallWarningForMajorChange(buildVersion: AnyObject?) -> Bool {
+    guard
+      let version = buildVersion as? String,
+      let majorLastInstallVersion = version.componentsSeparatedByString(".").first,
+      appVersion =  NSBundle.mainBundle().objectForInfoDictionaryKey("CFBundleShortVersionString") as? String,
+      majorAppVersion = appVersion.componentsSeparatedByString(".").first
+
+    else { return false}
+
+    return Int(majorAppVersion) > Int(majorLastInstallVersion)
+  }
+
+  func updatePodfileNameIfPossible(targets: [String: AnyObject]) {
+    if targets.keys.count == 1 {
+      let project = targets.keys.first!
+      let url = NSURL(fileURLWithPath: project)
+      let name = url.lastPathComponent!.stringByReplacingOccurrencesOfString(".xcproj", withString: "")
+      actionTitleLabel.stringValue = "Podfile for \(name)"
     }
   }
 
@@ -70,33 +89,50 @@ class CPPodfileViewController: NSViewController, NSTabViewDelegate {
   }
 
   @IBAction func install(obj: AnyObject) {
-    userProject.saveDocument(self)
     let options = InstallOptions(verbose: false)
-    installAction.performAction(.Install(options: options))
-    showConsoleTab(self)
+    performInstallAction(.Install(options: options))
   }
 
   @IBAction func installVerbose(obj: AnyObject) {
-    userProject.saveDocument(self)
     let options = InstallOptions(verbose: true)
-    installAction.performAction(.Install(options: options))
-    showConsoleTab(self)
+    performInstallAction(.Install(options: options))
   }
 
   @IBAction func installUpdate(obj: AnyObject) {
-    userProject.saveDocument(self)
     let options = InstallOptions(verbose: false)
-    installAction.performAction(.Update(options: options))
-    showConsoleTab(self)
+    performInstallAction(.Update(options: options))
   }
 
   @IBAction func installUpdateVerbose(obj: AnyObject) {
-    userProject.saveDocument(self)
     let options = InstallOptions(verbose: true)
-    installAction.performAction(.Update(options: options))
+    performInstallAction(.Update(options: options))
+  }
+
+  func performInstallAction(action: InstallActionType) {
+    userProject.saveDocument(self)
+
+    let lastInstalledVersion = userProject.xcodeIntegrationDictionary["cocoapods_build_version"]
+    if shouldShowInstallWarningForMajorChange(lastInstalledVersion) {
+      if promptForInstallMigration(lastInstalledVersion) == false { return }
+    }
+
+    installAction.performAction(action)
     showConsoleTab(self)
   }
 
+  func promptForInstallMigration(buildVersion: AnyObject?) -> Bool {
+    guard let
+      appVersion =  NSBundle.mainBundle().objectForInfoDictionaryKey("CFBundleShortVersionString") as? String,
+      version = buildVersion as? String else { return true }
+
+    let alert = NSAlert()
+    alert.messageText = ~"REINTEGRATION_ALERT_FORMAT_TITLE"
+    alert.informativeText = String(format: ~"REINTEGRATION_ALERT_FORMAT_MESSAGE", version, appVersion)
+    alert.addButtonWithTitle(~"REINTEGRATION_ALERT_CONFIRM")
+    alert.addButtonWithTitle(~"REINTEGRATION_ALERT_CANCEL")
+    return alert.runModal() == NSAlertFirstButtonReturn
+  }
+
   @IBOutlet var installMenu: NSMenu!
   @IBAction func showInstallOptions(button: NSButton) {
     guard let event = NSApp.currentEvent else { return }

app/CocoaPods/CPSpotlightDocumentSource.swift

@@ -47,7 +47,7 @@ class CPSpotlightDocumentSource: CPDocumentSource {
 
   func queryGatheringFinished(notification: NSNotification) {
     // let NSMetadataQuery finish when there are files available, if not finish the query
-    self.performSelector(Selector("queryFinished"), withObject: nil, afterDelay: 2.0)
+    self.performSelector(#selector(CPSpotlightDocumentSource.queryFinished), withObject: nil, afterDelay: 2.0)
   }
 
   func queryFinished() {

app/CocoaPods/CPUserProject.m

@@ -89,7 +89,6 @@ - (void)presentedItemDidChange
       });
     }
   }
-
 }
 
 @end

app/CocoaPods/Supporting Files/Localizable.strings

@@ -43,4 +43,9 @@
 "REPO_UPDATE_FAILED_NOTIFICATION_TITLE" = "Repo not Updated";
 
 "PLUGIN_FAILED_TO_INSTALL_MESSAGE" = "Failed to Install Plugins";
-"PLUGINS_ALL_INSTALLED_MESSAGE" = "Installed Plugins";
+"PLUGINS_ALL_INSTALLED_MESSAGE" = "Installed Plugins";
+
+"REINTEGRATION_ALERT_FORMAT_TITLE" = "Re-integration";
+"REINTEGRATION_ALERT_FORMAT_MESSAGE" = "CocoaPods is going to migrate your project from %@ to %@, this is considered a breaking change. To migrate, CocoaPods will re-install your integration from scratch, including re-downloading all Pods";
+"REINTEGRATION_ALERT_CONFIRM" = "Okay, lets do it";
+"REINTEGRATION_ALERT_CANCEL" = "Cancel";