Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eslint prettier integration #317

Merged
merged 3 commits into from
Sep 7, 2023
Merged

Fix eslint prettier integration #317

merged 3 commits into from
Sep 7, 2023

Conversation

kilemensi
Copy link
Member

@kilemensi kilemensi commented Sep 7, 2023

Description

Prettier 3 doesn't work with eslint-plugin-prettier 4. This PR upgrades eslint-plugin-prettier and clean up the code.

NOTE:

v7.32 of eslint-plugin-react switches to the new eslint configuration mechanism which breaks the linting. We'll have to manually switch to that when time allows.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code

@kilemensi kilemensi added bug Something isn't working dependencies Pull requests that update a dependency file labels Sep 7, 2023
@kilemensi kilemensi self-assigned this Sep 7, 2023
@vercel
Copy link

vercel bot commented Sep 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sensors-africa ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 9:44am

v7.32 introduces new configuration option which we'll need to manually
upgrade to.
@kilemensi kilemensi merged commit 5713955 into main Sep 7, 2023
1 check passed
@kilemensi kilemensi deleted the fix/eslint_prettier branch September 7, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant