-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API Implementation #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of things to discuss, with some changes I would apreciate to be made.
Updates the implementation from CodeMC/API. Unit tests pass. I will add I also added a |
GitHub is weird. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things that should be changed.
Main concern is the reliance on the Discord user, with the jenkins username only being optional. Not every user matches their GitHub and Discord names, and using something like the user's nickname is not a good aproach here.
Added a |
Co-authored-by: Andre_601 <[email protected]>
That should be all of them. I also upgraded Gradle to the most recent version. |
Co-authored-by: Andre_601 <[email protected]>
Removed `suspend` Modifiers from Kotlin API
- Remove Unused JavaContinutation - Fix Validation Command - Add Response Message for Change Password
Explicitly set Repository Link to Optional
- Add Logging for Connectivity - Fix Jenkins Authorization
- Fix Message Parsing for Success Message - Move API Methods before Message is Sent
- Add Reason for Deny Button - Fix `lacksRole` Method
Tested everything on a Bot with a Docker Setup. A few notes:
|
Add Database Check for `remove` Command
- Check Credentials for `/codemc validate` - Improve `/codemc validate` Responses - Improve Success with `/codemc change-password`
Merges into #1.
Description
This PR does the following:
username
andjobName
/repository/username
), Jenkins User (/job/username
), and Jenkins Job (/job/username/job/jobName
) automaticallyconfig.json
jenkins
,nexus
anddatabase
sections are now required to be inputted. Similar to Add Jenkins Automation to Accept Command #4, specify the host URLs, with admin login details that the bot should use.services
is available. This includes direct interaction with the current services via API. The sample includes theModerator
andAdministrator
roles.config.json.sample
for more information.codemc
Slash Commandremove
Admin Command #7validate
Admin Command #8project-url
parameter in the Accept command, calculated according to theconfig.json
instead8.9
..gitignore
.API Implementation
The implementation details of the API are on the repository, which performs tests against Jenkins and Nexus containers with similar configuration, and collects code coverage. Thus, specific API changes must be made to the repository, which will then be updated here.