Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix typo in project #1554

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: fix typo in project #1554

wants to merge 2 commits into from

Conversation

psxjoy
Copy link

@psxjoy psxjoy commented Nov 1, 2024

No description provided.

@psxjoy
Copy link
Author

psxjoy commented Nov 1, 2024

And I noticed may be is still a typo about CAHT2DB_AUTO_ROW_ID?

@psxjoy
Copy link
Author

psxjoy commented Nov 19, 2024

@jovezhong PTAL.

@jovezhong
Copy link
Contributor

Thanks for adding me as a reviewer. It looks good to me. However I am no a maintainer or committer of the project. I am a community user and also contributed a database connection to our project: https://github.com/timeplus-io/proton. You will need someone else to review and merge the code.

@psxjoy
Copy link
Author

psxjoy commented Nov 20, 2024

Thanks for adding me as a reviewer. It looks good to me. However I am no a maintainer or committer of the project. I am a community user and also contributed a database connection to our project: https://github.com/timeplus-io/proton. You will need someone else to review and merge the code.

haha,OK.
Anyway,thanks for your codereview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants