CYF-ITP - South Africa |Azharuddin Meyer | Module-User Focused Data-Form Controls | WEEK2 | #320
Conversation
✅ Deploy Preview for cyf-ufd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Really nice start @azharuddinmeyer, just a few comments on requirements!
Form-Controls/index.html
Outdated
| <input | ||
| type="text" | ||
| name="name" | ||
| id="name" | ||
| placeholder="Username" | ||
| required | ||
| /> |
There was a problem hiding this comment.
What validations might we want to check for the name field?
There was a problem hiding this comment.
Hi james, I added minlength and maxlength validations for my name field
Form-Controls/index.html
Outdated
| max="2024-11-16" |
There was a problem hiding this comment.
nice validations! however, the form currently allows me to submit without filling out this field. Could you fix that?
There was a problem hiding this comment.
Added a required field for my date field
jamesbaskerville
added
👀 Review Requirements
azharuddinmeyer
added
Needs Review
azharuddinmeyer
changed the title
azharuddinmeyer
changed the title
|
Form meets all acceptance criteria. HTML code has some syntax error. May I suggest using a HTML validator (https://validator.w3.org/) to check for potential syntax errors in your HTML code? As to further limit what value can go into the name input textfield, you can consider using the |
cjyuan
added
Reviewed
azharuddinmeyer
added
Needs Review
|
Good work !! You just have some issues in your CSS Code You can use this validator |
| </footer> | ||
| </body> | ||
| <body> | ||
| <div class="container"> |
There was a problem hiding this comment.
Hi Azharuddin, is there another element that can be used for semantic reasons?
We also want to think about accessibility when it comes to using elements.
There was a problem hiding this comment.
Hi Ryno, I fixed my footer using an address element.
COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.