Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set start time on time stamper component #1203

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Dedekind561
Copy link
Contributor

What does this change?

Sets the start time on the time stamper component.

Common Theme?

Updates params on the day plan default layout.

  • Yes

Issue number: #1002

Org Content?

Checklist

Who needs to know about this?

@Dedekind561 Dedekind561 changed the title set start time on time stamper component Set start time on time stamper component Nov 19, 2024
Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for cyf-sdc ready!

Name Link
🔨 Latest commit 084fe69
🔍 Latest deploy log https://app.netlify.com/sites/cyf-sdc/deploys/673c72c3e1a35800085e4862
😎 Deploy Preview https://deploy-preview-1203--cyf-sdc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for cyf-tracks ready!

Name Link
🔨 Latest commit 084fe69
🔍 Latest deploy log https://app.netlify.com/sites/cyf-tracks/deploys/673c72c3e14b6b0008f5f738
😎 Deploy Preview https://deploy-preview-1203--cyf-tracks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for cyf-launch ready!

Name Link
🔨 Latest commit 084fe69
🔍 Latest deploy log https://app.netlify.com/sites/cyf-launch/deploys/673c72c30e2eb60008c87d7d
😎 Deploy Preview https://deploy-preview-1203--cyf-launch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for cyf-curriculum canceled.

Name Link
🔨 Latest commit 084fe69
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/673c72c3a2678a0007fbc9b4

Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for cyf-programming ready!

Name Link
🔨 Latest commit 084fe69
🔍 Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/673c72c305b0a600081ab70f
😎 Deploy Preview https://deploy-preview-1203--cyf-programming.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 85 (🔴 down 15 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for cyf-piscine ready!

Name Link
🔨 Latest commit 084fe69
🔍 Latest deploy log https://app.netlify.com/sites/cyf-piscine/deploys/673c72c33d4fb50008fc7f3d
😎 Deploy Preview https://deploy-preview-1203--cyf-piscine.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 13 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for cyf-itd canceled.

Name Link
🔨 Latest commit 084fe69
🔍 Latest deploy log https://app.netlify.com/sites/cyf-itd/deploys/673c72c341dff7000864489c

Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for cyf-common canceled.

Name Link
🔨 Latest commit 084fe69
🔍 Latest deploy log https://app.netlify.com/sites/cyf-common/deploys/673c72c3efd7c40008a78dce

@Dedekind561
Copy link
Contributor Author

I've tried but alas failed to launch the curriculum repo in a codespace. So I'm just checking out the deploy preview and will double check again when I've got access to my other local machine.

Copy link
Member

@SallyMcGrath SallyMcGrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Can you add the param to cyf-org-theme toml?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

2 participants