This repository has been archived by the owner on Feb 9, 2024. It is now read-only.
London10 - Khalil Alhaydr - CYF-hotel-challenge #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
mira-shukla
reviewed
Jul 14, 2023
| <div className="CityDives"> | ||
| <TouristInfoCards cityId={0} /> | ||
| <TouristInfoCards cityId={1} /> | ||
| <TouristInfoCards cityId={2} /> |
There was a problem hiding this comment.
Is it possible to move these cityIds into a variable rather than each one individually?
| <div> | ||
| <header className="App-header">CYF Hotel</header>; | ||
| <img className="Logo-image" src="https://images.unsplash.com/photo-1615880484746-a134be9a6ecf?ixlib=rb-4.0.3&ixid=M3wxMjA3fDB8MHxzZWFyY2h8M3x8bW91bnRhaW4lMjBob3RlbHxlbnwwfHwwfHx8MA%3D%3D&auto=format&fit=crop&w=500&q=60"></img> | ||
| </div> |
There was a problem hiding this comment.
Great work, sometimes it is good practice to add 'alt' incase the image doesn't load. More info here.)
| @@ -0,0 +1,42 @@ | |||
| import React from "react"; | |||
|
|
|||
| const city = [ | |||
There was a problem hiding this comment.
Small thing but up to you it may be better to rename this to 'cities' as it is an array of cities.
| return ( | ||
| <div className="CitiesDiv"> | ||
| <div className="card"> | ||
| <img src={city[cityId].src} className="card-img-top" /> |
There was a problem hiding this comment.
is it possible to restructure city[cityId] so it is called from another level?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.