Fix permissions fetching for User Installable Bots #6457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Category: Core - Bot Class
Kowlin
added
the
Type: Bug
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.
Jackenmen
requested changes
Dec 24, 2024
Jackenmen
approved these changes
Dec 24, 2024
red-githubbot
bot
added
the
Changelog Entry: Pending
Jackenmen
added
Changelog Entry: Added
|
Huge thanks for this and all the work you do. Upgraded and my slash commands now work in threads (where the bot isn't). \o/ 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
This change fixes permissions regarding discord.Interactions and fetching permissions. Where this would fail where a bot isn't in the server (Yep, that's a thing now!) or doesn't have the channels cached in memory with interactions on User Installable Bots (UIBs) This fix pulls the permissions directly from the interaction, and gives the allowed permissions the interaction can use directly.
This will however sucks for bots trying to see if a person can ignore the ignore list. As its unclear to the bot if the author has manage_guild or similar permissions. But I see no other viable method of solving this.
Have the changes in this PR been tested?
Partially? (Lmao)