[config] prevents registering defaults for reserved identifiers #6459
+28
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Category: Core - API - Config
Kreusada
added
the
Type: Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Fixes #6290 by raising a
RuntimeErrorwhen registering config with an identifier that's already inConfig/Group/ValueobjectsIt does so using
__slots__, so that changes the behavior ofConfigobjects in that you can't set arbitrary attributes to them anymore.If that's a problem, we can addI went ahead and added it in case cog creators had set attributes on config__dict__to its__slots__just like I do toValue.I don't believe using
__slots__to solve this presents any other complications, but perhaps this should be solved another way (like using class attributes). Let me know and I can adjustHave the changes in this PR been tested?
Yes, at least through
toxwith a new test added, and the most common case "default"