Removed Edit Profile button and Added individuals buttons for edit profile pic and bio #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@developer-rachit Can you rebase and fix merge conflicts, then I will take a look again and see if we can merge? |
Codecov Report
@@ Coverage Diff @@
## development #293 +/- ##
===============================================
+ Coverage 26.96% 26.98% +0.02%
===============================================
Files 139 139
Lines 3620 3624 +4
===============================================
+ Hits 976 978 +2
- Misses 2644 2646 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Xazin
force-pushed
the
development
branch
13 times, most recently
from
5be7e86 to
77ff369
Compare
Xazin
force-pushed
the
development
branch
7 times, most recently
from
9ffa101 to
7fdfc72
Compare
Xazin
force-pushed
the
development
branch
3 times, most recently
from
05db9fc to
1ac5990
Compare
Xazin
reviewed
Jan 11, 2023
| color: Color(0xFF666666), | ||
| ), | ||
| textAlign: TextAlign.left, | ||
| Row( |
There was a problem hiding this comment.
Maybe this could be a Widget itself?
Xazin
reviewed
Jan 11, 2023
| ), | ||
| onPressed: () { | ||
| if (state.isBioEditing == true) { | ||
| /// TODO: Implement save profile image |
Xazin
reviewed
Jan 11, 2023
| ), | ||
| const SizedBox(height: 10), | ||
| if (state.isEditing == true) ...[ | ||
| if (state.isBioEditing == true) ...[ | ||
| //idhr bio editing start |
Xazin
reviewed
Jan 11, 2023
| ), | ||
| ), | ||
| ), | ||
| ], | ||
| ] else ...[ | ||
| // TODO only for MVP (remove later) |
There was a problem hiding this comment.
Not sure if this comment is still relevant?
Xazin
reviewed
Jan 11, 2023
| ); | ||
| context | ||
| .read<ProfileBloc>() | ||
| .add(EditProfilePic()); |
There was a problem hiding this comment.
I don't remember how this works, but shouldn't the image be passed to this event?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is regarding this suggestion #214
Updated Figma design as discussed with @Xazin
In these one requirement is pending, when Bio character counts exceed 150 then we need to disable the Save Bio btn.
I am not getting this how, I need @Xazin your assistance pls.