Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CI): Disable widget book for test job 🚀. #391

Conversation

wizlif
Copy link
Collaborator

@wizlif wizlif commented Apr 3, 2023

We can skip widget_book generation when running tests since the Widget Book files are already generated and cached in the analyze step of CI.

@wizlif wizlif added the WIP Work In Progress do not merge label Apr 3, 2023
@wizlif wizlif force-pushed the fix/ci/disable-widgetbook-for-test-job branch from 6283767 to 77f787d Compare April 3, 2023 10:32
@wizlif wizlif removed the WIP Work In Progress do not merge label Apr 3, 2023
@wizlif wizlif requested review from Xazin, a team and sarahaudina and removed request for a team April 3, 2023 10:42
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #391 (77f787d) into development (db8283d) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           development     #391      +/-   ##
===============================================
+ Coverage        65.65%   65.69%   +0.04%     
===============================================
  Files              161      161              
  Lines             4067     4066       -1     
===============================================
+ Hits              2670     2671       +1     
+ Misses            1397     1395       -2     
Impacted Files Coverage Δ
lib/core/config/network_config.dart 66.66% <100.00%> (+16.66%) ⬆️
lib/domain/crowdaction/crowdaction.dart 94.73% <100.00%> (ø)
lib/domain/participation/participation.dart 100.00% <100.00%> (ø)
lib/presentation/profile/profile_screen.dart 41.60% <100.00%> (+0.65%) ⬆️
.../presentation/shared_widgets/crowdaction_card.dart 96.77% <100.00%> (ø)
...esentation/shared_widgets/participant_avatars.dart 90.47% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Xazin
Copy link
Member

Xazin commented Apr 6, 2023

We could alternatively remove widgetbook and move it to the collaction_ui repository, and then all widgets in collaction_ui/packages/... need to be inside widgetbook. (Dependency by path inside Widgetbook package).

What do you think?

@wizlif
Copy link
Collaborator Author

wizlif commented Apr 6, 2023

That would be the best option, but will take some time as we shift slowly.

@Xazin
Copy link
Member

Xazin commented Apr 6, 2023

We could alternatively remove widgetbook and move it to the collaction_ui repository, and then all widgets in collaction_ui/packages/... need to be inside widgetbook. (Dependency by path inside Widgetbook package).

What do you think?

Related: CollActionteam/collaction_ui#4

@wizlif
Copy link
Collaborator Author

wizlif commented Apr 6, 2023

We could alternatively remove widgetbook and move it to the collaction_ui repository, and then all widgets in collaction_ui/packages/... need to be inside widgetbook. (Dependency by path inside Widgetbook package).
What do you think?

Related: CollActionteam/collaction_ui#4

Awesome, let me try to migrate atleast one or two widgets then we can sample.

@wizlif wizlif closed this May 2, 2023
@wizlif wizlif deleted the fix/ci/disable-widgetbook-for-test-job branch July 7, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants