Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move calls to http_response_code() before doing print() #293

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions proxy.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@ function debug_log($msg)

function errorExit($msg)
{
http_response_code(400);
print "<html><body>\n";
print "<h1>Socket proxy error</h1>\n";
print "<p>Error: " . htmlspecialchars($msg) . "</p>\n";
print "</body></html>\n";
error_log("richdocumentscode (proxy.php) error exit, PID: " . getmypid() . ", Message: $msg");
http_response_code(400);
exit();
}

Expand Down Expand Up @@ -242,7 +242,6 @@ function parseLastHeader(&$chunk, &$contentLength)
"hasTemplateSource":true
}';

http_response_code(200);
exit();
}

Expand Down Expand Up @@ -293,7 +292,6 @@ function parseLastHeader(&$chunk, &$contentLength)
fclose($local);
}

http_response_code(200);
exit();
}
// URL into this server of the proxy script.
Expand Down