Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue when using constructor with custom arguments #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anthrax63
Copy link

@anthrax63 anthrax63 commented May 6, 2022

Problem:
When i use constructor with some custom arguments like this:

@Service({
    name: 'hello-service',
    constructOverride: false,
})
class HelloService extends moleculer.Service {
    constructor(broker: ServiceBroker, private readonly param1: string, private readonly param2: string) {
        super(broker);
    }

    @Action({
        name: 'say.hello',
    })
    async sayHello() {
        return 'Hello!';
    }
}

any additional parameters are lost because only 2 parameters are passed to the superclass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant