Add slapcomp compatibility #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigRoy
reviewed
Mar 23, 2018
| self.flow_file.setEnabled(state) | ||
| self.brows_file_btn.setEnabled(state) | ||
|
|
||
| def on_brows_clicked(self): |
BigRoy
reviewed
Mar 23, 2018
|
|
||
| cmds.setAttr("{}.priority".format(instance), settings["priority"]) | ||
| # Format to Maya default | ||
| # attr_name = key[0].lower() + key[1:] |
|
Some typos, other than that looks nice. |
|
Fixed the minor points, only merge when config has been merged |
|
Also typo in variable name right? :) |
BigRoy
reviewed
Mar 30, 2018
| @@ -29,14 +37,28 @@ def setup_ui(self): | |||
|
|
|||
| publish = QtWidgets.QCheckBox("Suspend Publish Job") | |||
| defaultlayer = QtWidgets.QCheckBox("Include Default Render Layer") | |||
| run_slap_comp = QtWidgets.QCheckBox("Run Slap Comp") | |||
|
|
|||
| brows_hlayout = QtWidgets.QHBoxLayout() | |||
There was a problem hiding this comment.
Hehe, sorry @aardschok - noticed just right now there are actually much more variables with brows instead of browse - this line and the lines below (45 to 54, 120, 131)
BigRoy
reviewed
Mar 30, 2018
| @@ -29,21 +51,21 @@ def query(argument): | |||
|
|
|||
| def get_machine_list(debug=None): | |||
| """Fetch the machine list (slaves) from Deadline""" | |||
| AVALON_SESSION = debug or avalon.Session["AVALON_DEADLINE"] | |||
| AVALON_SESSION = debug or api.Session["AVALON_DEADLINE"] | |||
There was a problem hiding this comment.
Does it make more sense to call this variable avalon_deadline or something? It's not actually the session. :) Also in the other methods.
There was a problem hiding this comment.
LOL, this slipped in without me even noticing. I know I wanted to call it AVALON_DEADLINE :')
|
After the config PR has been updated we can merge this along with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds UI elements to control slap comp submission
Minor code improvements