feat: Added HPLC Reader (as tar archive) #102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
Do you please have a test server? |
|
Can be tested here |
herrdivad
approved these changes
Jun 5, 2024
cllde8
force-pushed
the
101-new-hplc-reader
branch
from
ba808fc to
bccf784
Compare
|
The profile can be downloaded here: |
PiTrem
changed the title
PiTrem
requested changes
Nov 5, 2024
| str2bool~=1.1 | ||
| parser-binary @ git+https://github.com/ComPlat/BinaryParser@main |
There was a problem hiding this comment.
does this install the binary artifact from the repo or does this trigger the building from the source ?
There was a problem hiding this comment.
What dependencies are needed at runtime ? Does the Readme needs an update
StarmanMartin
force-pushed
the
101-new-hplc-reader
branch
from
47354a8 to
a4332ca
Compare
|
This reader throws an error if the tar/gz file contains no folder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reades Data (no Metadata) from hplc file set. set has to be send as tar archive
X15291.D.tar.gz
X15294.D.tar.gz
close #101