Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated metadata display #76

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

headri
Copy link
Collaborator

@headri headri commented Dec 4, 2024

no line breaks in key and show tooltip if key too long

no line breaks in key and show tooltip if key too long
@headri headri requested a review from StarmanMartin December 4, 2024 13:41
Copy link
Collaborator

@StarmanMartin StarmanMartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if you could fix the one comment, thanks.

@@ -349,18 +349,42 @@ class ProfileForm extends Component {

renderMetadata(metadata) {
return (
<>
<style type="text/css">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style tag should not be in the html body. It should be in the head instead. Especially if the css part is static and does not have to be changed in the React element dynamically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants