[Feature Request]: User selectable colors for bypassed and muted nodes

[JorgeR81]

Is there an existing issue for this?

• I have searched the existing issues and checked the recent builds/commits

What would your feature do ?

I have a lot of bypassed nodes on my workflows, and I find all the pink colors too distracting.

I would like to use a dark color ( similar to the muted nodes ).

But the best way to deal with this is probably to let the user select the color for each use case, since everyone has its own preferences.

---

If this is too complex, just and an option to switch the current colors:

• dark = bypassed
• pink = muted

Proposed workflow

.

Additional information

No response

[mcmonkey4eva]

The correct way to do this is probably via the Themes system that lets you customize colors in general, which internally maps to the ColorPalette.ts classes, however it's currently not designed in a way that's particular amenable to being extended and used fully.

Notably bypass/mute is implemented inside app.ts, and ColorPalette.ts requires app.ts to be ready at import time, ie app.ts cannot import ColorPalette.ts to actually read color data from it (ow). This happens because ColorPalette is treated as an extension, not a core component, meaning it uses app.registerExtension inside itself.

Also it's organized into 'comfy base' and 'litegraph base', neither of which are correct for "new color" (albeit either can happily used despite technical incorrectness, or just make a new category)

So some reorganization of this code is needed before it can be used to fully allow free customization of colors.
Or, we could define the colors as just random variables somewhere, and let the extension update them, which is in line with how the current code for it is implemented, but is very much a hack.

[mcmonkey4eva]

PR for the hacky version #993

Green bypass to demonstrate

Only did bypass atm - currently muted notes just go transparent and don't alter color, so allowing coloring them would need to be done separately

[JorgeR81]

If you're planning a more robust implementation for this:

Why not make bypassed / muted states independent from color ?
Maybe just add some transparency and icons for bypassed / muted states, similar to the pin icon ( Comfy-Org/litegraph.js#152 )

Then the user could also select to have no color at all for these states.