Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow custom bypass color #993

Merged
merged 3 commits into from
Oct 2, 2024
Merged

allow custom bypass color #993

merged 3 commits into from
Oct 2, 2024

Conversation

mcmonkey4eva
Copy link
Contributor

NOTE: see my comment here #964 regardless the design of the theme/color palette system (the current impl feels very hacky, and it's made worse by trying to add a color that isn't explicitly an upstreamed value in litegraph or css, as is the case here).

Regardless, this PR does let you change the color of node bypass if you want, for example here I made it green (#00FF00)
image

Copy link
Member

@huchenlei huchenlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The node color configuration should be in litegraph_base category.

@mcmonkey4eva
Copy link
Contributor Author

it's not valid to be there (as that's, for, yknow, litegraph) but it doesn't break anything, so sure why not - moved

@huchenlei huchenlei merged commit a7a0035 into main Oct 2, 2024
9 checks passed
@huchenlei huchenlei deleted the allow-custom-bypass-color branch October 2, 2024 14:50
@JorgeR81
Copy link

JorgeR81 commented Oct 2, 2024

Where are the settings for this ? ( I don't see it in v1.3.6 )

Do we have to create a custom color palette ?
Is there a guide to do this ?

@mcmonkey4eva
Copy link
Contributor Author

mcmonkey4eva commented Oct 3, 2024

Yes, create a custom color palette
At the top of settings, there's Color Palette, just select your preference and click "Export"
image

that'll give you a json file. Open it up in a text editor, find node bypass color
image
and edit it to a hex color you like, eg #00FF00 for glowing neon green lol

Also at the top change the name:
image

Then back in the settings menu click "Import" and select your file
image

Then go bypass something
image

Hopefully in the future we can have an in-UI color picker thingy for this stuff instead of editing json, but this works for now

@JorgeR81
Copy link

JorgeR81 commented Oct 3, 2024

It's working fine. Thanks !

But I can only use 1 custom palette at a time.

When I import a new one, the previous one is gone.

Is this a known issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants