Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BrowserTest] Fix flaky gallery test #2150

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

[BrowserTest] Fix flaky gallery test #2150

wants to merge 7 commits into from

Conversation

christian-byrne
Copy link
Collaborator

@christian-byrne christian-byrne commented Jan 3, 2025

Make tests added in #2125 more robust by:

  • Using alt text (filename) to locate images instead of indices
  • Adding 64ms delay after keyboard navigation
  • Removing ws fixture

┆Issue is synchronized with this Notion page by Unito

@christian-byrne christian-byrne requested a review from a team as a code owner January 3, 2025 22:56
@christian-byrne christian-byrne marked this pull request as draft January 3, 2025 23:07
@huchenlei
Copy link
Member

I am going to disable these tests first before they are fixed. #2158

@christian-byrne
Copy link
Collaborator Author

It's difficult to debug because I cannot reproduce locally. The flakiness only occurs on the gallery tests.

@webfiltered
Copy link
Contributor

Options to increase flakiness:

  1. Run playwright with --workers=10. Depending on your specs this may actually need to be lower.
  2. Run tests inside a resource-constrained VM, with 2 vCPUs. Our GH action runners only run 2 threads.
  3. Recompile a large C project whilst running tests. 😃

@christian-byrne
Copy link
Collaborator Author

christian-byrne commented Jan 5, 2025

Options to increase flakiness:

  1. Run playwright with --workers=10. Depending on your specs this may actually need to be lower.
  2. Run tests inside a resource-constrained VM, with 2 vCPUs. Our GH action runners only run 2 threads.
  3. Recompile a large C project whilst running tests. 😃

Those are good ideas. I tried options 1 and 3 but it's difficult to find the exact right amount of throttling. Tests begin to fail as I increase network and processor throttling but many other tests fail as well.

I will try option 2 tomorrow with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants