Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom light color palette #2156

Merged
merged 4 commits into from
Jan 4, 2025
Merged

Add support for custom light color palette #2156

merged 4 commits into from
Jan 4, 2025

Conversation

huchenlei
Copy link
Member

@huchenlei huchenlei commented Jan 4, 2025

Resolves #2155

Previous only the system light theme was treated as light theme. User cannot define custom light theme. This PR allows user define a custom light theme with extra flag light_theme in the color palette json.

Example light_red_fg.json:

{
  "id": "light-red-fg",
  "name": "Light (Red fg)",
  "light_theme": true,
  "colors": {
    "node_slot": {},
    "litegraph_base": {},
    "comfy_base": {
      "fg-color": "#ff0000"
    }
  }
}

image

┆Issue is synchronized with this Notion page by Unito

@huchenlei huchenlei requested review from a team as code owners January 4, 2025 21:07
@huchenlei huchenlei changed the title Add support for custom light theme Add support for custom light color palette Jan 4, 2025
@huchenlei huchenlei added the New Browser Test Expectations New browser test screenshot should be set by github action label Jan 4, 2025
@huchenlei huchenlei added New Browser Test Expectations New browser test screenshot should be set by github action and removed New Browser Test Expectations New browser test screenshot should be set by github action labels Jan 4, 2025
@huchenlei huchenlei merged commit e65653c into main Jan 4, 2025
2 checks passed
@huchenlei huchenlei deleted the light_flag branch January 4, 2025 23:53
@Poulpii
Copy link

Poulpii commented Jan 5, 2025

Thanks to you @huchenlei.
This new feature will work on next released ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Browser Test Expectations New browser test screenshot should be set by github action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Light Theme
2 participants