Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve menu accessibility #2163

Merged
merged 2 commits into from
Jan 5, 2025
Merged

Improve menu accessibility #2163

merged 2 commits into from
Jan 5, 2025

Conversation

christian-byrne
Copy link
Collaborator

@christian-byrne christian-byrne commented Jan 5, 2025

Improves menu accessibility by adding aria attributes to buttons without text. "When a button doesn't have an accessible name, screen readers announce it as 'button', making it unusable for users who rely on screen readers." (Deque)

acc-tree

This PR also adds a tooltip to the New Workflow button to the right of the tabs.

┆Issue is synchronized with this Notion page by Unito

@christian-byrne christian-byrne requested a review from a team as a code owner January 5, 2025 01:26
@huchenlei huchenlei merged commit 972af19 into main Jan 5, 2025
10 checks passed
@huchenlei huchenlei deleted the aria-labels branch January 5, 2025 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants