Update Settings schema

[christian-byrne]

Adds missing fields from core settings to Settings schema.

┆Issue is synchronized with this Notion page by Unito

[huchenlei]

BTW is there a way to enforce the schema typing? How were you performing the check?

[christian-byrne]

BTW is there a way to enforce the schema typing? How were you performing the check?

I was just doing it like this in strict mode:

-const zSettings = z.record(z.any()).and(
-  z
-    .object({
+const zSettings =
+  z.object({
@@ -10,7 +9,7 @@
       'Comfy.DevMode': z.boolean(),
       'Comfy.Workflow.ShowMissingNodesWarning': z.boolean(),
       'Comfy.Workflow.ShowMissingModelsWarning': z.boolean(),
       'Comfy.DisableFloatRounding': z.boolean(),
+      ...
@@ -55,6 +54,6 @@
       'LiteGraph.Canvas.MaximumFps': z.number(),
       'Comfy.Workflow.ConfirmDelete': z.boolean()
     })
-    .optional()
 )

[huchenlei]

Oh yea, enabling ts-strict changes zod schema behaviour. I think the gradual ts strict check does not modify the zod behaviour that is why.

[christian-byrne]

Oh, I see now. I just tried and it also works with "noPropertyAccessFromIndexSignature": true while strict mode is off. It may be better if there's a schema for core settings which can be enforced. And then the schema for settings is the union of that and any.