feat: Save user preference for crashes after confirmation dialog #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huchenlei
requested changes
Dec 2, 2024
src/config/comfySettings.ts
Outdated
| @@ -39,11 +41,16 @@ export class ComfySettings { | |||
| this.settings = JSON.parse(fileContent); | |||
| } | |||
|
|
|||
| public saveSettings() { | |||
| fs.writeFileSync(this.filePath, JSON.stringify(this.settings), 'utf-8'); | |||
There was a problem hiding this comment.
This is very problematic as the file content can be newer than the snapshot state when we read it during electron app start.
I'm not sure I understand. The errors processed here for Sentry are Electron errors and crashes; if Electron is in erroneous or crashing state how can it communicate with frontend (assuming you mean ComfyUI-frontend)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
┆Issue is synchronized with this Notion page by Unito