-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Change Pin Icon #152
Comments
@webfiltered The meaning of this issue was to replace the current (ugly) pin icon with a prettier one (as also requested here Comfy-Org/ComfyUI_frontend#831) Is there a plan to change it? |
Ah, I misread. Worth noting: it's just text: 📌, so this feature is currently implemented in litegraph using |
I could probably expand on that a little. Being text, it's determined by the system it's running on. You can see HCL's screenshots on #120 show a different icon to yours. The font specified for group titles is |
Is it not possible to implement just that single icon (at least for now) instead of using the system fonts? |
It's a bit more complex than that - keep in mind Litegraph itself has no imports, and renders this all using canvas, not html elements. Need to confirm we can (legally) rip the font file out of the lib, copy the code for how it's inserted, get the right code point, then measure the current Arial text render length, and add a new fillText on the end using the custom font. Which we would also have to verify is loaded... It might be easier than it sounds, but it's just not that simple to do properly. |
Ref
Possible Implementation
The PrimeIcons font is already loaded with icons mapped to unicode sequences:
Comparison
The text was updated successfully, but these errors were encountered: