Cclcc savemenu thumbnail #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KKhanhH
force-pushed
the
cclcc-savemenu-thumbnail
branch
2 times, most recently
from
cab77ba to
aa45e9d
Compare
added 6 commits
September 16, 2024 21:19
Working thumbnail images, with save and load Fix Quicksave Entries order in CCLCC menu OpenGL Renderer function for fetching pixels from texture Resize image utility function Changed how some libraries are fetched using CMake FetchContent
KKhanhH
force-pushed
the
cclcc-savemenu-thumbnail
branch
from
67fb150 to
3381d3c
Compare
MrRevo3D
reviewed
Sep 17, 2024
src/game.cpp
Outdated
| @@ -379,6 +379,10 @@ void Render() { | |||
| CCLCC::YesNoTrigger::YesNoTriggerPtr->Render(); | |||
| } | |||
| } | |||
|
|
|||
| if(SaveSystem::Implementation) { | |||
There was a problem hiding this comment.
nitpick, missing space between if and (
MrRevo3D
reviewed
Sep 17, 2024
| @@ -32,6 +32,16 @@ class Renderer : public BaseRenderer { | |||
|
|
|||
| uint32_t SubmitTexture(TexFmt format, uint8_t* buffer, int width, | |||
| int height) override; | |||
| std::vector<uint8_t> GetImageFromTexture( uint32_t texture, | |||
There was a problem hiding this comment.
Some formatting weirdness here and below. Please reformat with clang-format we usually use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thumbnails are a 16 bit sensation