Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include component icons as library assets #203

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Conversation

Arlodotexe
Copy link
Member

Needs CommunityToolkit/Tooling-Windows-Submodule#129

This PR consists of a tooling update that fixes an asset issue in the sample app.

Component icons and other .png files are now included as library assets instead of using the /SourceAssets workaround needed for this (now closed) issue: unoplatform/uno#2502.

@Arlodotexe Arlodotexe added bug Something isn't working enhancement New feature or request sample app 🖼️ labels Aug 30, 2023
@Arlodotexe Arlodotexe self-assigned this Aug 30, 2023
@michael-hawker
Copy link
Member

Oh, wait this one is still broken and appears to be looking in the wrong place:

image

HeaderedContentControl doc... Miss this project maybe @Arlodotexe?

Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Arlodotexe looks good then, approving so you'll be all set once the Tooling PR merges to update the pointer here and get this merged.

@Arlodotexe Arlodotexe enabled auto-merge (rebase) August 30, 2023 16:23
@Arlodotexe Arlodotexe merged commit 172cb6e into main Aug 30, 2023
9 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/assets/png-files branch August 30, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request sample app 🖼️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants