Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tooling pointer #572

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

michael-hawker
Copy link
Member

@michael-hawker michael-hawker commented Nov 27, 2024

Commit for CommunityToolkit/Tooling-Windows-Submodule#232

This updates our version of CsWinRT to avoid issues with our StaggeredLayout sample crashing. We can't update to 2.2 yet (which provides better error messages), until its updated in the WASDK, but 2.1.6 seems to be good enough for now.

Fixes

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • Tested code with current supported SDKs
  • New component
    • Documentation has been added
    • Sample in sample app has been added
    • Analyzers are passing for documentation and samples
    • Icon has been created (if new sample) following the Thumbnail Style Guide and templates
  • Tests for the changes have been added (if applicable)
  • Header has been added to all new source files
  • Contains NO breaking changes

Other information

@michael-hawker michael-hawker force-pushed the llama/update-tooling-cswinrt branch from 3d13603 to a023310 Compare December 3, 2024 19:16
@michael-hawker
Copy link
Member Author

Alright, updated tooling pointer to main now that base tooling commit is in.

@michael-hawker michael-hawker marked this pull request as ready for review December 3, 2024 19:16
@michael-hawker michael-hawker enabled auto-merge (rebase) December 3, 2024 19:18
@michael-hawker michael-hawker merged commit 2e64c30 into main Dec 4, 2024
23 checks passed
@Arlodotexe Arlodotexe deleted the llama/update-tooling-cswinrt branch December 4, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants