Fix: ColorPicker Binding failed #579
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -291,7 +292,7 @@ | |||
| animations:Implicit.HideAnimations="{StaticResource HideTransitions}" | |||
| animations:Implicit.ShowAnimations="{StaticResource ShowTransitions}" | |||
| ItemsSource="{TemplateBinding CustomPaletteColors}" | |||
| SelectedValue="{Binding RelativeSource={RelativeSource TemplatedParent}, Path=Color, Mode=TwoWay}" | |||
| SelectedValue="{Binding RelativeSource={RelativeSource TemplatedParent}, Path=Color, Converter={StaticResource NullToTransparentConverter}, Mode=TwoWay}" | |||
There was a problem hiding this comment.
Is TargetNullValue not sufficient here for some reason?
There was a problem hiding this comment.
Since the null problem arises with BindBack and not Bind, I guess TargetNullValue won't help.
Arlodotexe
reviewed
Dec 5, 2024
components/ColorPicker/src/Converters/NullToTransparentConverter.cs
Outdated
Show resolved
Hide resolved
Arlodotexe
reviewed
Dec 5, 2024
components/ColorPicker/src/Converters/NullToTransparentConverter.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GridView.SelectedValueto null is transient behavior. It does not affect the originalColorPickerbehavior.Fixes
closes: #414
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Other information