Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unit tests assertion parameters for expected and actual values #642

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fix unit tests assertion parameters for expected and actual values #642

wants to merge 7 commits into from

Conversation

GabrieleMessina
Copy link
Contributor

@GabrieleMessina GabrieleMessina commented Mar 13, 2023 •
edited
Loading

Fix ordering of params in assertions with "expected" as first argument and "actual" as second.

Closes #55

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@GabrieleMessina GabrieleMessina marked this pull request as ready for review March 16, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix unit tests assertion parameters for expected and actual values
1 participant
@GabrieleMessina